Closed
Bug 1158519
Opened 9 years ago
Closed 9 years ago
Remove last music file from jshint xfail.list
Categories
(Firefox OS Graveyard :: Gaia::Build, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: kgrandon, Assigned: kgrandon)
References
Details
Attachments
(1 file)
It seems there is one last file in the jshint xfail.list (apps/music/js/metadata.js). This file appears to not be included in the repo anymore, so perhaps we can just remove it?
|
Assignee | |
Comment 1•9 years ago
|
||
It looks like the file exists in 2.1, but not 2.2 onwards: https://github.com/mozilla-b2g/gaia/blob/v2.1/apps/music/js/metadata.js
|
||
Comment 2•9 years ago
|
||
|
|
Assignee | |
Comment 3•9 years ago
|
||
Comment on attachment 8597631 [details] [review] [gaia] KevinGrandon:bug_1158519_music_remove_last_jshint > mozilla-b2g:master This is only removing a file from xfail.list which does not exist anymore. Assuming that jshint passes on try we should be good to go. R=me to save on review cycles.
Attachment #8597631 -
Flags: review+
|
|
Assignee | |
Updated•9 years ago
|
Keywords: checkin-needed
|
|
||
Updated•9 years ago
|
Keywords: checkin-needed
|
|
||
Comment 4•9 years ago
|
||
Autolander could not locate a review from a user within the suggested reviewer list. Either the patch author or the reviewer should be in the suggested reviewer list.
|
|
Assignee | |
Comment 5•9 years ago
|
||
Going to land this manually: https://github.com/mozilla-b2g/gaia/commit/bd45d85cc32386a384871b53554a217346a239dd
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Component: Gaia::Music → Gaia::Build
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•