Closed Bug 1158523 Opened 6 years ago Closed 5 years ago

Correct accessibility hint for Reload button (non-imperative, Double-tap instead of tap)

Categories

(Firefox for iOS :: Browser, defect)

Other
iOS
defect
Not set
minor

Tracking

()

RESOLVED FIXED

People

(Reporter: dusek, Assigned: dusek)

References

(Blocks 1 open bug)

Details

(Keywords: access)

Attachments

(1 file)

47 bytes, text/x-github-pull-request
bnicholson
: review+
Details | Review
User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_10_3) AppleWebKit/600.5.17 (KHTML, like Gecko) Version/8.0.5 Safari/600.5.17

Steps to reproduce:

1. Open a webpage in Firefox
2. Launch VoiceOver (e.g. triple-click on Home button)
3. Put VoiceOver cursor on the "Reload" button in the bottom toolbar, let it read "Reload" and hear what it reads after a while.


Actual results:

It reads "Tap to reload the page."


Expected results:

It should read "Reloads the page."
1. With VoiceOver, it's double-tap, not single tap like without VoiceOver
2. accessibility hint should not be imperative - see "Discussion" for accessibilityHint at https://developer.apple.com/library/prerelease/ios/documentation/UIKit/Reference/UIAccessibility_Protocol/index.html#//apple_ref/occ/instp/NSObject/accessibilityHint
3. It should not repeat the action taken to activate the item (i.e. should not mention any kind of "tapping"

Note that the long-press hints for for back and forward buttons indicated explicit action to be taken ("double tap and hold") as that is the non-default action and quite rare for VoiceOver users, so explicit guidance is needed. (writing about it now, I am thinking if the hint there can be made non-imperative; I just borrowed it from Safari...)

Also there is a question whether the hint is needed at all (i.e. if "Reload, button" is sufficient to not require further hints to what the UI element does).
Blocks: iosa11y
Keywords: access
Status: UNCONFIRMED → NEW
Ever confirmed: true
Severity: normal → minor
Assignee: nobody → dusek
Status: NEW → ASSIGNED
Attached file Pull Request
Attachment #8632295 - Flags: review?(bnicholson)
Attachment #8632295 - Flags: review?(bnicholson) → review+
https://github.com/mozilla/firefox-ios/commit/42bb8c27c160e4f65b034280a6c312e3fd812781
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.