1158572 - Classification bug comments for non-buildbot jobs are missing a job name, since they don't have a buildername

Status: RESOLVED FIXED

(Tree Management :: Treeherder, defect, P2)

Description

[David Baron :dbaron: (⌚️UTC-5, no longer working on Mozilla)]

When starring via treeherder, comments usually look like bug 1131627 comment 36, which has a line:
buildname: Windows 8 64-bit mozilla-inbound debug test mochitest-devtools-chrome-2

However, when starring a Linux mulet mochitest, there's no such line, which means that essential data is missing from the bug.  See bug 1158571 comment 1.


(I'm guessing this is related to the latter being run in taskcluster.)

Comment 1

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

Attachment: PR 675

I'm sure there's probably more to this like updating a test or something (and I haven't even built this locally to see if it works), but thought I'd post it up now before I forgot about it.

Comment 2

[Ed Morley [:emorley]]

Comment on attachment 8626437 [details] [review]
PR 675

Left a comment on the PR - mostly looks good, just needs the failing test fixing :-)

Comment 3

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

Comment on attachment 8626437 [details] [review]
PR 675

Test should be fixed.

Comment 4

[Ed Morley [:emorley]]

Comment on attachment 8626437 [details] [review]
PR 675

Looks good; will merge now so I can get this deployed to stage this afternoon.
Have tweaked the commit message to mention this is a fake name for bug comments only (rather than elsewhere in the UI etc).

Comment 5

[Treeherder GitHub Bugbot]

Commit pushed to master at https://github.com/mozilla/treeherder

https://github.com/mozilla/treeherder/commit/35101264bc8685233b3c61a293cae5b5ef148804
Bug 1158572 - Add a job name to non-buildbot classification bug comments