1158710 - Don't emulate mozSettings entries every time the phone boots

Status: RESOLVED INVALID

(Firefox OS Graveyard :: Performance, defect)

Description

[Tim Guan-tin Chien [:timdream] (please needinfo)]

https://hg.mozilla.org/mozilla-central/annotate/37d60e3b8be6/dom/settings/SettingsDB.jsm#l70

Apparently we load settings.json and update the default value of the database EVERY TIME the phone boots.

Gonna try mstone and buildID check just like AppsUtils.jsm do.

Comment 1

[Tim Guan-tin Chien [:timdream] (please needinfo)]

Attachment: Patch v1.0

This patch introduces two prefs just AppsUtils.jsm to denote whether or not we have updated the database. I simply copy the isFirstRun() function there.

This is obviously not the best approach but it's the "done" approach. I would imagine the safer way (to against power loss during upgrading db) would be save these two values into the same database directly (w/ the same transaction), but I don't want to spend too much time on this -- bug 1112092 is more valuable than this one.

AppUtils.isFirstRun() is not tested -- I presume this is too small to test too.

Comment 2

[Tim Guan-tin Chien [:timdream] (please needinfo)]

Will broadcast at dev-b2g/dev-gaia once this landed, since this patch implies settings.json changes (w/ |make install-gaia| will not be picked up unless there is a accompany buildID change.

Comment 3

[Tim Guan-tin Chien [:timdream] (please needinfo)]

Wait -- upgradeSchema() only hits when SETTINGSDB_VERSION changes...