Closed
Bug 1158716
Opened 9 years ago
Closed 9 years ago
The module name of AudioChannelManager is illegal
Categories
(Firefox OS Graveyard :: Gaia::System::Audio Mgmt, defect)
Firefox OS Graveyard
Gaia::System::Audio Mgmt
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: evanxd, Assigned: evanxd)
Details
Attachments
(1 file, 1 obsolete file)
`window.AudioChannelManager` is already existed before our audio channel management module[1] was landed. So we need to change the name. [1]: http://bugzil.la/1100822
|
Assignee | |
Comment 1•9 years ago
|
||
Patch for the bug. Waiting for CI[1]. [1]: https://treeherder.mozilla.org/#/jobs?repo=gaia&revision=2d2a10228ad548eebc33bed0be4032fb0f97f369
|
|
Assignee | |
Updated•9 years ago
|
Attachment #8597878 -
Attachment mime type: text/plain → text/x-github-pull-request
|
|
Assignee | |
Comment 2•9 years ago
|
||
Comment on attachment 8597878 [details] Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/29737/files https://github.com/mozilla-b2g/gaia/pull/29737/files
Attachment #8597878 -
Attachment filename: file_1158716.txt → test
|
|
Assignee | |
Comment 3•9 years ago
|
||
Attachment #8597878 -
Attachment is obsolete: true
|
|
Assignee | |
Comment 4•9 years ago
|
||
Honestly I don't know the purpose of `window.AudioChannelManager` currently existed in the `window` of each app. I cannot find any code in Gaia uses that.
|
|
Assignee | |
Comment 5•9 years ago
|
||
Comment on attachment 8597880 [details] Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/29737/files Hi Alive, Cold you help to review the patch? The CI[1] looks good. Thanks. [1]: https://treeherder.mozilla.org/#/jobs?repo=gaia&revision=2d2a10228ad548eebc33bed0be4032fb0f97f369
Attachment #8597880 -
Flags: review?(alive)
|
||
Comment 6•9 years ago
|
||
Comment on attachment 8597880 [details] Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/29737/files nit: The naming is confusing, too. I prefer 'AudioChannelService' to reflect the gecko part.
Attachment #8597880 -
Flags: review?(alive) → review+
|
|
Assignee | |
Comment 7•9 years ago
|
||
Sure, thanks for the review. Waiting for CI[1]. [1]: https://treeherder.mozilla.org/#/jobs?repo=gaia&revision=3b7d52a8ef7abcf2f5ebf8c7e3d49bfba287ab38
|
|
Assignee | |
Comment 8•9 years ago
|
||
Waiting for that the tree is reopened.
|
|
Assignee | |
Comment 9•9 years ago
|
||
CI is good now.
|
|
Assignee | |
Comment 10•9 years ago
|
||
master: https://github.com/mozilla-b2g/gaia/commit/d15bf2d1ac6a9d5c0eab0e1863a5aac84cdfe1c3
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•