Closed Bug 1158716 Opened 6 years ago Closed 6 years ago

The module name of AudioChannelManager is illegal

Categories

(Firefox OS Graveyard :: Gaia::System::Audio Mgmt, defect)

defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: evanxd, Assigned: evanxd)

Details

Attachments

(1 file, 1 obsolete file)

`window.AudioChannelManager` is already existed before our audio channel management module[1] was landed.

So we need to change the name.

[1]: http://bugzil.la/1100822
Attachment #8597878 - Attachment mime type: text/plain → text/x-github-pull-request
Comment on attachment 8597878 [details]
Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/29737/files

https://github.com/mozilla-b2g/gaia/pull/29737/files
Attachment #8597878 - Attachment filename: file_1158716.txt → test
Honestly I don't know the purpose of `window.AudioChannelManager` currently existed in the `window` of each app.

I cannot find any code in Gaia uses that.
Comment on attachment 8597880 [details]
Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/29737/files

Hi Alive,

Cold you help to review the patch?
The CI[1] looks good.

Thanks.

[1]: https://treeherder.mozilla.org/#/jobs?repo=gaia&revision=2d2a10228ad548eebc33bed0be4032fb0f97f369
Attachment #8597880 - Flags: review?(alive)
Comment on attachment 8597880 [details]
Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/29737/files

nit: The naming is confusing, too. I prefer 'AudioChannelService' to reflect the gecko part.
Attachment #8597880 - Flags: review?(alive) → review+
Waiting for that the tree is reopened.
CI is good now.
master: https://github.com/mozilla-b2g/gaia/commit/d15bf2d1ac6a9d5c0eab0e1863a5aac84cdfe1c3
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.