Closed
Bug 1158725
Opened 10 years ago
Closed 10 years ago
Share link button has stopped working in latest nightly
Categories
(Hello (Loop) :: Client, defect, P1)
Hello (Loop)
Client
Tracking
(firefox40 verified)
| Tracking | Status | |
|---|---|---|
| firefox40 | --- | verified |
People
(Reporter: standard8, Assigned: standard8)
References
Details
(Keywords: regression, Whiteboard: [context])
Attachments
(1 file)
|
5.48 KB,
patch
|
mikedeboer
:
review+
|
Details | Diff | Splinter Review |
I've just noticed that the share button has stopped working in the latest nightly. This looks to be since bug 1142514 landed - we missed passing some props down.
|
Assignee | |
Comment 1•10 years ago
|
||
This adds the missing props that are needed.
Attachment #8597889 -
Flags: review?(mdeboer)
|
||
Comment 2•10 years ago
|
||
Comment on attachment 8597889 [details] [diff] [review]
Share link button has stopped working in latest nightly. Pass the necessary props to the component.
Review of attachment 8597889 [details] [diff] [review]:
-----------------------------------------------------------------
Whoops! Thanks for fixing this. My bad :/
Attachment #8597889 -
Flags: review?(mdeboer) → review+
|
|
Assignee | |
Comment 3•10 years ago
|
||
Iteration: --- → 40.2 - 27 Apr
Points: --- → 1
Rank: 4
Flags: qe-verify+
Flags: firefox-backlog+
Target Milestone: --- → mozilla40
|
|
Assignee | |
Updated•10 years ago
|
Whiteboard: [context]
|
||
Comment 5•10 years ago
|
||
|
||
Updated•10 years ago
|
QA Contact: bogdan.maris
|
||
Comment 6•10 years ago
|
||
Reproduced the initial issue using old Nightly build (2015-04-27), verified that the issue is fixed on Windows 7 64-bit, Mac OS X 10.9.5 and Ubuntu 14.04 32-bit using latest Aurora and latest Nightly. Marking as verified fixed and dropping qe-verify.
You need to log in
before you can comment on or make changes to this bug.
Description
•