Closed Bug 1158725 Opened 9 years ago Closed 9 years ago

Share link button has stopped working in latest nightly

Categories

(Hello (Loop) :: Client, defect, P1)

defect
Points:
1

Tracking

(firefox40 verified)

VERIFIED FIXED
mozilla40
Iteration:
40.2 - 27 Apr
Tracking Status
firefox40 --- verified

People

(Reporter: standard8, Assigned: standard8)

References

Details

(Keywords: regression, Whiteboard: [context])

Attachments

(1 file)

I've just noticed that the share button has stopped working in the latest nightly. This looks to be since bug 1142514 landed - we missed passing some props down.
This adds the missing props that are needed.
Attachment #8597889 - Flags: review?(mdeboer)
Comment on attachment 8597889 [details] [diff] [review]
Share link button has stopped working in latest nightly. Pass the necessary props to the component.

Review of attachment 8597889 [details] [diff] [review]:
-----------------------------------------------------------------

Whoops! Thanks for fixing this. My bad :/
Attachment #8597889 - Flags: review?(mdeboer) → review+
https://hg.mozilla.org/integration/fx-team/rev/a12d2234381c
Iteration: --- → 40.2 - 27 Apr
Points: --- → 1
Rank: 4
Flags: qe-verify+
Flags: firefox-backlog+
Target Milestone: --- → mozilla40
Blocks: 1115340
Whiteboard: [context]
https://hg.mozilla.org/mozilla-central/rev/a12d2234381c
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
QA Contact: bogdan.maris
Reproduced the initial issue using old Nightly build (2015-04-27), verified that the issue is fixed on Windows 7 64-bit, Mac OS X 10.9.5 and Ubuntu 14.04 32-bit using latest Aurora and latest Nightly. Marking as verified fixed and dropping qe-verify.
Status: RESOLVED → VERIFIED
Flags: qe-verify+
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: