Closed
Bug 1158751
Opened 9 years ago
Closed 9 years ago
Port NO_JS_MANIFEST changes | mozbuild.frontend.reader.SandboxValidationError: calendar/base/backend/icaljs/moz.build
Categories
(MailNews Core :: Build Config, defect)
MailNews Core
Build Config
Tracking
(Not tracked)
RESOLVED
FIXED
Thunderbird 40.0
People
(Reporter: ssitter, Assigned: Fallen)
References
Details
(Keywords: intermittent-failure)
Attachments
(4 files)
992 bytes,
patch
|
ssitter
:
review+
|
Details | Diff | Splinter Review |
775 bytes,
patch
|
iannbugzilla
:
review+
|
Details | Diff | Splinter Review |
628 bytes,
patch
|
iannbugzilla
:
review+
|
Details | Diff | Splinter Review |
712 bytes,
patch
|
Gijs
:
review+
iannbugzilla
:
feedback+
|
Details | Diff | Splinter Review |
https://treeherder.mozilla.org/logviewer.html#?job_id=17204&repo=comm-central > mozbuild.frontend.reader.SandboxValidationError: > ============================== > ERROR PROCESSING MOZBUILD FILE > ============================== > The error occurred while processing the following file or one of the files it includes: > /builds/slave/tb-c-cen-m64-ntly-000000000000/build/calendar/base/backend/icaljs/moz.build > The error occurred when validating the result of the execution. The reported error is: > A .js component was specified in EXTRA_COMPONENTS or EXTRA_PP_COMPONENTS without a matching .manifest file. See https://developer.mozilla.org/en/XPCOM/XPCOM_changes_in_Gecko_2.0 . > *** Fix above errors and then restart with "make -f client.mk build" > make[3]: *** [configure] Error 1
Reporter | ||
Comment 1•9 years ago
|
||
Seems to be triggered by Bug 1155816 and solution would be to move NO_JS_MANIFEST to moz.build.
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Assignee | ||
Comment 6•9 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try-comm-central&revision=cf54f896537b
Assignee | ||
Updated•9 years ago
|
Keywords: intermittent-failure
Summary: Build fails: mozbuild.frontend.reader.SandboxValidationError: calendar/base/backend/icaljs/moz.build → Port NO_JS_MANIFEST changes | mozbuild.frontend.reader.SandboxValidationError: calendar/base/backend/icaljs/moz.build
Assignee | ||
Updated•9 years ago
|
Attachment #8597945 -
Attachment description: Fix - v1 → Calendar - v1
Assignee | ||
Comment 7•9 years ago
|
||
Attachment #8597948 -
Flags: review?(neil)
Reporter | ||
Updated•9 years ago
|
Attachment #8597945 -
Flags: review?(ssitter) → review+
OS: Unspecified → All
Product: Calendar → MailNews Core
Hardware: Unspecified → All
Version: Lightning 4.2 → Trunk
Comment on attachment 8597948 [details] [diff] [review] Inspector - v1 Stealing as was working on similar patch
Attachment #8597948 -
Flags: review?(neil) → review+
Assignee | ||
Comment 9•9 years ago
|
||
Attachment #8597958 -
Flags: review?(mh+mozilla)
Assignee | ||
Comment 10•9 years ago
|
||
Attachment #8597961 -
Flags: review?(iann_bugzilla)
Comment 11•9 years ago
|
||
Comment on attachment 8597961 [details] [diff] [review] Chatzilla - v1 Looks right but Gijs/Silver should sign off (whomever comes first)
Attachment #8597961 -
Flags: review?(iann_bugzilla)
Attachment #8597961 -
Flags: review?(gijskruitbosch+bugs)
Attachment #8597961 -
Flags: review?(bugzilla-mozilla-20000923)
Attachment #8597961 -
Flags: feedback+
Comment 12•9 years ago
|
||
Comment on attachment 8597958 [details] [diff] [review] Venkman - v1 Not sure if anyone still packages Venkman, but might as well for completeness
Attachment #8597958 -
Flags: review?(mh+mozilla) → review+
Updated•9 years ago
|
Attachment #8597961 -
Flags: review?(gijskruitbosch+bugs)
Attachment #8597961 -
Flags: review?(bugzilla-mozilla-20000923)
Attachment #8597961 -
Flags: review+
Assignee | ||
Comment 13•9 years ago
|
||
http://hg.mozilla.org/venkman/rev/46a23f47058f http://hg.mozilla.org/chatzilla/rev/0b8debe4c6d3 http://hg.mozilla.org/dom-inspector/rev/9af90c864080 https://hg.mozilla.org/comm-central/rev/f43af3ffcd1c
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 42.0
Updated•9 years ago
|
Target Milestone: Thunderbird 42.0 → Thunderbird 40.0
Comment 14•9 years ago
|
||
Exception: Variable NO_JS_MANIFEST is defined in /mnt/compile/mozilla/thunderbird/trunk/source/mozilla/extensions/venkman/Makefile.in. It should only be defined in moz.build files. *** Fix above errors and then restart with\ "make -f client.mk build" make[1]: *** [configure] Fehler 1
Comment 15•9 years ago
|
||
This is after "./client.py checkout" and "time nice make -f client.mk" with MOZ_OBJDIR=/foo/bar/
Reporter | ||
Comment 16•9 years ago
|
||
Venkman is no longer build (Bug 1029513) and therefore its source code is not pulled by client.py. In my comm-central tree the mozilla/extensions/venkman folder doesn't exists at all. The code in your tree is maybe a leftover from previous times. I assume you can manually update it or remove it.
Comment 17•9 years ago
|
||
rm -rf mozilla/extensions/venkman/ and removing it from .mozconfig worked. Thanks!
You need to log in
before you can comment on or make changes to this bug.
Description
•