1158751 - Port NO_JS_MANIFEST changes | mozbuild.frontend.reader.SandboxValidationError: calendar/base/backend/icaljs/moz.build

Status: RESOLVED FIXED

(MailNews Core :: Build Config, defect)

Description

[Stefan Sitter [:ssitter]]

https://treeherder.mozilla.org/logviewer.html#?job_id=17204&repo=comm-central

> mozbuild.frontend.reader.SandboxValidationError:
> ==============================
> ERROR PROCESSING MOZBUILD FILE
> ==============================
> The error occurred while processing the following file or one of the files it includes:
> /builds/slave/tb-c-cen-m64-ntly-000000000000/build/calendar/base/backend/icaljs/moz.build
> The error occurred when validating the result of the execution. The reported error is:
> A .js component was specified in EXTRA_COMPONENTS or EXTRA_PP_COMPONENTS without a matching .manifest file. See https://developer.mozilla.org/en/XPCOM/XPCOM_changes_in_Gecko_2.0 .
> *** Fix above errors and then restart with "make -f client.mk build"
> make[3]: *** [configure] Error 1

Comment 1

[Stefan Sitter [:ssitter]]

Seems to be triggered by Bug 1155816 and solution would be to move NO_JS_MANIFEST to moz.build.

Comment 2

[Legacy TBPL/Treeherder Robot]

log: https://treeherder.mozilla.org/logviewer.html#?repo=comm-central&job_id=17202
repository: comm-central
start_time: 2015-04-27T03:03:10
who: ssitter[at]gmail[dot]com
machine: bld-linux64-spot-1013
buildname: TB Linux comm-central nightly
revision: 95bf19990f85

mozbuild.frontend.reader.SandboxValidationError:
make[2]: *** [configure] Error 1
make[1]: *** [/builds/slave/tb-c-cen-lx-ntly-0000000000000/build/objdir-tb/Makefile] Error 2
make: *** [build] Error 2

Comment 3

[Legacy TBPL/Treeherder Robot]

log: https://treeherder.mozilla.org/logviewer.html#?repo=comm-central&job_id=17204
repository: comm-central
start_time: 2015-04-27T03:06:36
who: ssitter[at]gmail[dot]com
machine: bld-lion-r5-052
buildname: TB OS X 10.7 comm-central nightly
revision: 95bf19990f85

mozbuild.frontend.reader.SandboxValidationError:
make[3]: *** [configure] Error 1
make[2]: *** [/builds/slave/tb-c-cen-m64-ntly-000000000000/build/objdir-tb/i386/Makefile] Error 2
make[1]: *** [build] Error 2
make: *** [build] Error 2

Comment 4

[Legacy TBPL/Treeherder Robot]

log: https://treeherder.mozilla.org/logviewer.html#?repo=comm-central&job_id=17203
repository: comm-central
start_time: 2015-04-27T03:03:10
who: ssitter[at]gmail[dot]com
machine: bld-linux64-spot-088
buildname: TB Linux x86-64 comm-central nightly
revision: 95bf19990f85

mozbuild.frontend.reader.SandboxValidationError:
make[2]: *** [configure] Error 1
make[1]: *** [/builds/slave/tb-c-cen-l64-ntly-000000000000/build/objdir-tb/Makefile] Error 2
make: *** [build] Error 2

Comment 5

[Legacy TBPL/Treeherder Robot]

log: https://treeherder.mozilla.org/logviewer.html#?repo=comm-central&job_id=17206
repository: comm-central
start_time: 2015-04-27T03:02:41
who: ssitter[at]gmail[dot]com
machine: b-2008-ix-0165
buildname: TB WINNT 5.2 comm-central nightly
revision: 95bf19990f85

mozbuild.frontend.reader.SandboxValidationError:
mozmake.exe[2]: *** [configure] Error 1
mozmake.exe[1]: *** [c:/builds/moz2_slave/tb-c-cen-w32-ntly-000000000000/build/objdir-tb/Makefile] Error 2
mozmake.exe: *** [build] Error 2

Comment 6

[Philipp Kewisch [:Fallen][📱📆]]

Attachment: Calendar - v1

https://treeherder.mozilla.org/#/jobs?repo=try-comm-central&revision=cf54f896537b

Comment 7

[Philipp Kewisch [:Fallen][📱📆]]

Attachment: Inspector - v1

Comment 8

[Ian Neal]

Comment on attachment 8597948 [details] [diff] [review]
Inspector - v1

Stealing as was working on similar patch

Comment 9

[Philipp Kewisch [:Fallen][📱📆]]

Attachment: Venkman - v1

Comment 10

[Philipp Kewisch [:Fallen][📱📆]]

Attachment: Chatzilla - v1

Comment 11

[Ian Neal]

Comment on attachment 8597961 [details] [diff] [review]
Chatzilla - v1

Looks right but Gijs/Silver should sign off (whomever comes first)

Comment 12

[Ian Neal]

Comment on attachment 8597958 [details] [diff] [review]
Venkman - v1

Not sure if anyone still packages Venkman, but might as well for completeness

Comment 13

[Philipp Kewisch [:Fallen][📱📆]]

http://hg.mozilla.org/venkman/rev/46a23f47058f
http://hg.mozilla.org/chatzilla/rev/0b8debe4c6d3
http://hg.mozilla.org/dom-inspector/rev/9af90c864080
https://hg.mozilla.org/comm-central/rev/f43af3ffcd1c

Comment 14

[Ben Bucksch (:BenB)]

Exception: Variable NO_JS_MANIFEST is defined in /mnt/compile/mozilla/thunderbird/trunk/source/mozilla/extensions/venkman/Makefile.in. It should only be defined in moz.build files.
*** Fix above errors and then restart with\
               "make -f client.mk build"
make[1]: *** [configure] Fehler 1

Comment 15

[Ben Bucksch (:BenB)]

This is after "./client.py checkout" and "time nice make -f client.mk" with MOZ_OBJDIR=/foo/bar/

Comment 16

[Stefan Sitter [:ssitter]]

Venkman is no longer build (Bug 1029513) and therefore its source code is not pulled by client.py. In my comm-central tree the mozilla/extensions/venkman folder doesn't exists at all. The code in your tree is maybe a leftover from previous times. I assume you can manually update it or remove it.

Comment 17

[Ben Bucksch (:BenB)]

rm -rf mozilla/extensions/venkman/ and removing it from .mozconfig worked.
Thanks!