Closed Bug 1158766 Opened 9 years ago Closed 9 years ago

Pin datasource dependency using a tagged version not commit SHA

Categories

(Tree Management :: Treeherder, defect, P3)

Product:
Tree Management
Component:
Treeherder
Type:
defect

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: emorley, Assigned: emorley)

References

Details

The requirements file lists the datasource dependency as:
https://github.com/jeads/datasource/archive/2f09c9cc8700be71c1e63bc4f34c6cc05ffc5a66.zip#datasource

However peep special-cases URLs that look like SHAs and intentionally always downloads them. This means on Travis/deploys we continually re-download and re-install datasource, which invalidates the Travis cache, causing a 60s upload of the 'new' cache.

I asked jeads to add me as a collaborator on the datasource repo, which means I can add a tag/release corresponding to the latest release (which is latest master / the same SHA as we're already using anyway), and we can then use that archive URL.

Ideally we'd just release on Pypi, but there is already a package with the same name - and in the future we want to move away from datasource anyway - so this is a simpler short term fix.
Commit pushed to master at https://github.com/mozilla/treeherder

https://github.com/mozilla/treeherder/commit/45ba99054236b0fac30fe0b7790e00ae231e5221
Bug 1158766 - Pin datasource dependency using a tagged version not SHA

This is a no-op, the v0.6 release tag corresponds to the same revision,
it just avoids peeps SHA special-casing which causes continual
re-installation of the package & subsequent Travis cache invalidation.

https://github.com/jeads/datasource/releases/tag/v0.6
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.