1158868 - PeerConnection should not depend on navigator.onLine

Status: RESOLVED FIXED

(Core :: WebRTC, defect)

Description

[Valentin Gosu [:valentin] (he/him)]

As part of bug 786419 I changed PeerConnection.js to check navigator.onLine in order to determine if connectivity is present. However, if we mean to have navigator.onLine illustrate network connectivity, this means while offline we could not open PeerConnections to localhost.
It is best to check instead if that specific appId is offline.

Comment 1

[Valentin Gosu [:valentin] (he/him)]

Attachment: PeerConnection should not depend on navigator.onLine

Comment 2

[Randell Jesup [:jesup] (needinfo me)]

Comment on attachment 8598313 [details] [diff] [review]
PeerConnection should not depend on navigator.onLine

Review of attachment 8598313 [details] [diff] [review]:
-----------------------------------------------------------------

r+, though it's unclear to me what the implications are of (or more to the point, reasons for) the appid being offline would be; I'm just guessing.

Comment 3

[Valentin Gosu [:valentin] (he/him)]

(In reply to Randell Jesup [:jesup] from comment #2)
> r+, though it's unclear to me what the implications are of (or more to the
> point, reasons for) the appid being offline would be; I'm just guessing.

Although the API for Gaia hasn't landed yet (bug 1042745), disabling network connectivity for individual appIDs is supported. ioService.setOffline(appId, nsIAppOfflineInfo::OFFLINE) should close all connections for the given appId, and should not allow that app to create any new connections.

Comment 4

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/fcc036a85f19

Comment 5

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/fcc036a85f19