1158893 - Delete the old Cython compiled log parser files as part of deploy

Status: RESOLVED FIXED

(Tree Management :: Treeherder: Infrastructure, defect, P3)

Description

[Ed Morley [:emorley]]

During deploy we delete the .pyc files, but don't currently remove the output from the Cython build of the log parser files:

./treeherder/log_parser/artifactbuildercollection.c
./treeherder/log_parser/parsers.c
./treeherder/log_parser/artifactbuilders.c
./treeherder/log_parser/artifactbuildercollection.so
./treeherder/log_parser/parsers.so
./treeherder/log_parser/artifactbuilders.so

This means that they don't get rebuild after eg changing the version of Cython (bug 1158395).

We should purge them too, and let the later existing build step re-create them.

Comment 1

[Ed Morley [:emorley]]

Attachment: Delete any existing Cython build output as part of deploy

Comment 2

[Mauro Doglio [:mdoglio]]

Right, I didn't think about this case :)

Comment 3

[Treeherder GitHub Bugbot]

Commit pushed to master at https://github.com/mozilla/treeherder

https://github.com/mozilla/treeherder/commit/343d112f930c21b1516f7a9353812e9ff99926d9
Bug 1158893 - Delete any existing Cython build output as part of deploy

The Cython build process creates .c and .so files in the log_parser
directory, which only get re-created if the original source changes.
We recently updated the version of Cython, however this doesn't trigger
re-building them. To avoid surprises, we should purge them like we do
for the .pyc files.

In addition, there is no need to delete .pyc files from the UI source
directory, since that does not contain any Python files.

Comment 4

[Ed Morley [:emorley]]

Comment on attachment 8598105 [details] [review]
Delete any existing Cython build output as part of deploy

Bah wrong bug.