1158896 - prevent dead code from being generated in lower.py

Status: RESOLVED FIXED

(Core :: IPC, defect)

Description

[Nathan Froyd [:froydnj]]

Coverity was complaining that we have things like:

    if ((!(actor))) {
        return false;
    }

    if ((!(actor))) {
        return false;
    }

in the generated code, as the second return will clearly never be hit.  To
address this, let's remove a redundant call to dtorPrologue.

Comment 1

[Nathan Froyd [:froydnj]]

Attachment: prevent dead code from being generated in lower.py

I can confirm that Send__delete__ instances now only have one check for null
actors, not two.  This ought to be an easy review.

Comment 2

[Ben Turner (not reading bugmail, use the needinfo flag!)]

Comment on attachment 8598097 [details] [diff] [review]
prevent dead code from being generated in lower.py

Thanks!

Comment 3

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/f284c64e5537

Comment 4

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/f284c64e5537