Closed Bug 1158896 Opened 5 years ago Closed 5 years ago

prevent dead code from being generated in lower.py

Categories

(Core :: IPC, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla40
Tracking Status
firefox40 --- fixed

People

(Reporter: froydnj, Assigned: froydnj)

References

(Blocks 1 open bug)

Details

(Keywords: coverity)

Attachments

(1 file)

Coverity was complaining that we have things like:

    if ((!(actor))) {
        return false;
    }

    if ((!(actor))) {
        return false;
    }

in the generated code, as the second return will clearly never be hit.  To
address this, let's remove a redundant call to dtorPrologue.
I can confirm that Send__delete__ instances now only have one check for null
actors, not two.  This ought to be an easy review.
Attachment #8598097 - Flags: review?(bent.mozilla)
Keywords: coverity
Comment on attachment 8598097 [details] [diff] [review]
prevent dead code from being generated in lower.py

Thanks!
Attachment #8598097 - Flags: review?(bent.mozilla) → review+
https://hg.mozilla.org/mozilla-central/rev/f284c64e5537
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla40
You need to log in before you can comment on or make changes to this bug.