1158992 - 720p The Smart Collections are fuzzy

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Homescreen, defect)

Description

[Patryk Adamczyk [:patryk] UX]

Attachment: 2015-04-27-12-41-28.png

see screenshot, these smart collection icons are fuzzy.

Comment 1

[Gregor Wagner [:gwagner]]

Do we have the right assets here?

Comment 2

[Kevin Grandon :kgrandon]

(In reply to Gregor Wagner [:gwagner] from comment #1)
> Do we have the right assets here?

Probably not. It looks like we currently have assets for 60, 90, 120, and 135.

We should try to get assets in the dimensions of home screen icons. This would be: 84, 126, 142, 189, 284.

Patryk - do you know who can generate icons for us in the proper sizes?

Comment 3

[Kevin Grandon :kgrandon]

I can update the assets after we get them.

Comment 4

[Patryk Adamczyk [:patryk] UX]

Peter can you provide the needed sizes? Thanks!

Comment 5

[Gregor Wagner [:gwagner]]

Ping?

Comment 6

[Peter La]

Hi, I won't be able to take care of this until next Wednesday.  I'll see if Eric can help out before then.

Comment 7

[Peter La]

Attachment: SmartCollectionsIcons5Sizes.zip

Hi Kevin,

Sorry this took a while - here are the 10 collections icons in the 5 sizes you specified.

I think we currently have too many icon sizes when you combine these with the ones currently specified for E.Me - is there anyway to collapse it to fewer sizes?  Maybe just use the 84, 126, 142, 189, 284 and scale as needed?  Just a thought.  10 sizes is a lot.  It might be more trouble than it's worth at this point, just wanted to ask the question.

Peter

Comment 8

[Peter La]

Ping Kevin.

Comment 9

[Reza Akhavan [:jedireza]]

Attachment: PR: Add new smart collection icon images

Comment 10

[Kevin Grandon :kgrandon]

Thanks for jumping on that Reza!

Comment 11

[Chris Lord [:cwiiis]]

Comment on attachment 8616255 [details] [review]
PR: Add new smart collection icon images

One question I'd like answered on github before r+ - I don't suppose any investigation was done into whether we could improve the scaling quality and not require so many more icons?

Comment 12

[Chris Lord [:cwiiis]]

(In reply to Chris Lord [:cwiiis] from comment #11)
> Comment on attachment 8616255 [details] [review]
> PR: Add new smart collection icon images
> 
> One question I'd like answered on github before r+ - I don't suppose any
> investigation was done into whether we could improve the scaling quality and
> not require so many more icons?

Oops, ignore that last question, thought this was a different bug - comment on github still stands though.

Comment 13

[Reza Akhavan [:jedireza]]

(In reply to Chris Lord [:cwiiis] from comment #12)
> Oops, ignore that last question, thought this was a different bug - comment
> on github still stands though.

Type corrected and PR updated.

Comment 14

[Chris Lord [:cwiiis]]

Comment on attachment 8616255 [details] [review]
PR: Add new smart collection icon images

Really seems we have way more icons than is necessary here (really 135, 126 and 120...? I'm not convinced that anyone would tell the difference between 120 at 1x zoom and 135 at 0.89x), but collections will be going away in v3 anyway.

Comment 15

[Reza Akhavan [:jedireza]]

(In reply to Chris Lord [:cwiiis] from comment #14)
> Really seems we have way more icons than is necessary here

Agreed.

(In reply to Chris Lord [:cwiiis] from comment #14)
> but collections will be going away in v3 anyway.

Ah. I didn't know that.

Comment 16

[Ryan VanderMeulen [:RyanVM]]

Master: https://github.com/mozilla-b2g/gaia/commit/2b02a78c4244be85936aa66568d9c68ed81fa50c