Only append library path for updater if it is a unique value

RESOLVED FIXED in Firefox 40

Status

()

Toolkit
Application Update
RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: bbondy, Assigned: bbondy)

Tracking

unspecified
mozilla40
Points:
---

Firefox Tracking Flags

(firefox40 fixed)

Details

Attachments

(1 attachment)

(Assignee)

Description

3 years ago
Bug 1158866 appends to the library path but it should check if the path already exists first.  If Firefox is updated multiple times in sequence without being closed, it can lead to having a long library path.
(Assignee)

Updated

3 years ago
Summary: Add support for MAR verification on Linux → Only append library path for updater if it is a unique value
(Assignee)

Comment 1

3 years ago
Created attachment 8598397 [details] [diff] [review]
Patch v1.
Attachment #8598397 - Flags: review?(robert.strong.bugs)
(Assignee)

Comment 2

3 years ago
Comment on attachment 8598397 [details] [diff] [review]
Patch v1.

Review of attachment 8598397 [details] [diff] [review]:
-----------------------------------------------------------------

Will resubmit
Attachment #8598397 - Flags: review?(robert.strong.bugs)
(Assignee)

Comment 3

3 years ago
Comment on attachment 8598397 [details] [diff] [review]
Patch v1.

Sorry this was fine, I had seen that some builds were failing on oak but it's just from a mozconfig check python script unrelated to this.
Attachment #8598397 - Flags: review?(robert.strong.bugs)
Attachment #8598397 - Flags: review?(robert.strong.bugs) → review+

Comment 4

3 years ago
I am not sure how likely it is to cause a problem, but simply using strstr() could lead to some false matches.  For example, if LD_LIBRARY_PATH contains /home/user/firefox37 and pathToAppend is /home/user/firefox, then pathToAppend will not be added.  Unless installDirPath.get() always returns a / terminated string?
(Assignee)

Comment 5

3 years ago
That's true but I'm not particularly concerned since these env vars are per process. If this was PATH I'd be more concerned.  Feel free to file a follow up though if you disagree. I'll land this one as is.
(Assignee)

Updated

3 years ago
Target Milestone: --- → mozilla40
https://hg.mozilla.org/mozilla-central/rev/6e0c202e4469
Status: NEW → RESOLVED
Last Resolved: 3 years ago
status-firefox40: --- → fixed
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.