Closed Bug 1159090 Opened 5 years ago Closed 5 years ago

Only append library path for updater if it is a unique value

Categories

(Toolkit :: Application Update, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla40
Tracking Status
firefox40 --- fixed

People

(Reporter: bbondy, Assigned: bbondy)

References

Details

Attachments

(1 file)

Bug 1158866 appends to the library path but it should check if the path already exists first.  If Firefox is updated multiple times in sequence without being closed, it can lead to having a long library path.
Summary: Add support for MAR verification on Linux → Only append library path for updater if it is a unique value
Attached patch Patch v1.Splinter Review
Attachment #8598397 - Flags: review?(robert.strong.bugs)
Comment on attachment 8598397 [details] [diff] [review]
Patch v1.

Review of attachment 8598397 [details] [diff] [review]:
-----------------------------------------------------------------

Will resubmit
Attachment #8598397 - Flags: review?(robert.strong.bugs)
Comment on attachment 8598397 [details] [diff] [review]
Patch v1.

Sorry this was fine, I had seen that some builds were failing on oak but it's just from a mozconfig check python script unrelated to this.
Attachment #8598397 - Flags: review?(robert.strong.bugs)
I am not sure how likely it is to cause a problem, but simply using strstr() could lead to some false matches.  For example, if LD_LIBRARY_PATH contains /home/user/firefox37 and pathToAppend is /home/user/firefox, then pathToAppend will not be added.  Unless installDirPath.get() always returns a / terminated string?
That's true but I'm not particularly concerned since these env vars are per process. If this was PATH I'd be more concerned.  Feel free to file a follow up though if you disagree. I'll land this one as is.
Target Milestone: --- → mozilla40
https://hg.mozilla.org/mozilla-central/rev/6e0c202e4469
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.