1159091 - gecko: Show emulator-x86-kk as it's own platform

Status: RESOLVED FIXED

(Taskcluster :: General, defect)

Comment 1

[James Lal [:lightsofapollo]]

Quick update here...

My most recent try push https://treeherder.allizom.org/#/jobs?repo=try&revision=ba3d90257f32

So on the TC side this is very simple (some in tree config changes) but somewhere in treeherder we seem to be filtering out some platforms (in this case kk :/) so I need to dig some more into what is going on under the hood.

Comment 2

[Josh Cheng [:josh]]

Hi James,
Do you have any update? Thanks

Comment 3

[Hsin-Yi Tsai (she/her) [:hsinyi]]

This would help a lot to distinguish the test results of emu-kk and emu-x86-kk.

Comment 4

[Edgar Chen [:edgar] (Parental leave until Oct. 09.)]

Looks like we could just add a new platform in https://github.com/mozilla/treeherder/blob/master/ui/js/values.js#L43. But I am not sure if there is other things need to be done in treeherder.

Comment 5

[Edgar Chen [:edgar] (Parental leave until Oct. 09.)]

Attachment: [treeherder:master] PR #842, Add platform mappings for emualtor x86 kk

Comment 6

[Edgar Chen [:edgar] (Parental leave until Oct. 09.)]

Attachment: [TC] Patch, v1

Comment 7

[Edgar Chen [:edgar] (Parental leave until Oct. 09.)]

Comment on attachment 8644774 [details] [review]
[treeherder:master] PR #842, Add platform mappings for emualtor x86 kk

Currently the build result of emulator-x86-kk is put under `B2G KK Emulator` with x86 tag [1] and all the test of emulator-x86-kk and emulator-kk are mixed. It will be clearer if the result of emulator-kk and emulator-x86-kk could show in separated row. :)

Hi :emorley, may I have your feedback here? Is any other thing need to be done in treeherder? Thank you.

[1] https://treeherder.allizom.org/#/jobs?repo=try&revision=df9a7dd1362c

Comment 8

[Ed Morley [:emorley]]

Comment on attachment 8644774 [details] [review]
[treeherder:master] PR #842, Add platform mappings for emualtor x86 kk

This is everything that you need to do on the Treeherder side :-)

Comment 9

[Treeherder GitHub Bugbot]

Commit pushed to master at https://github.com/mozilla/treeherder

https://github.com/mozilla/treeherder/commit/84d8a71b716fe1dfea39631acb9632eaa6776125
Bug 1159091 - Add platform mappings for emulator x86 kk

Comment 10

[Ed Morley [:emorley]]

Comment on attachment 8644777 [details] [diff] [review]
[TC] Patch, v1

I'm not really familiar enough with the Taskcluster configs to know if this is now right.

Comment 11

[Greg Arndt [:garndt]]

I believe this is what you're looking for:
https://dxr.mozilla.org/mozilla-central/source/testing/taskcluster/tasks/builds/b2g_emulator_x86_kk_opt.yml#19

Comment 12

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 8644777 [details] [diff] [review]
[TC] Patch, v1

Review of attachment 8644777 [details] [diff] [review]:
-----------------------------------------------------------------

Can you fix the | workerType: emualtor-x86-kk| typo in b2g_emulator_x86_kk_opt.yml while you're at it?

Comment 13

[Greg Arndt [:garndt]]

I have made sure that the "emulator-x86-kk" is available within our provisioner so that if the spelling change is corrected in the task definition, we do not have any interrupted service (hopefully).

Comment 14

[Edgar Chen [:edgar] (Parental leave until Oct. 09.)]

(In reply to Ryan VanderMeulen [:RyanVM UTC-4] from comment #12)
> Comment on attachment 8644777 [details] [diff] [review]
> [TC] Patch, v1
> 
> Review of attachment 8644777 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> Can you fix the | workerType: emualtor-x86-kk| typo in
> b2g_emulator_x86_kk_opt.yml while you're at it?

Sure, I will do this. And thanks Greg's comment in comment #13.

Comment 15

[Edgar Chen [:edgar] (Parental leave until Oct. 09.)]

Attachment: [TC] Patch, v2

Comment 16

[Edgar Chen [:edgar] (Parental leave until Oct. 09.)]

Comment on attachment 8645764 [details] [diff] [review]
[TC] Patch, v2

Try runs: https://treeherder.allizom.org/#/jobs?repo=try&revision=65e4b7b119fd

I can see emulator-x86-kk build showing in separated platform, but still have `x86` tag. I thought |groupSymbol: "?"| would remove the `x86` tag, did I miss anything?

Comment 17

[Greg Arndt [:garndt]]

Not sure what's going on here, but looking at the task definition [1] that was submitted, there is no mention of that group symbol.  Perhaps this job name was cached on the treeherder side.  I'm a bit at a loss.


[1] https://queue.taskcluster.net/v1/task/VVE95Ym7TaOfzByCYrgKvg

Comment 18

[Edgar Chen [:edgar] (Parental leave until Oct. 09.)]

Comment on attachment 8645764 [details] [diff] [review]
[TC] Patch, v2

Review of attachment 8645764 [details] [diff] [review]:
-----------------------------------------------------------------

Since the task was submitted correctly, I would like to land this change first.
Hi Greg, may I have your review? Thank you.

Comment 19

[Greg Arndt [:garndt]]

Comment on attachment 8645764 [details] [diff] [review]
[TC] Patch, v2

Review of attachment 8645764 [details] [diff] [review]:
-----------------------------------------------------------------

LGTM

Comment 20

[Pulsebot]

https://hg.mozilla.org/integration/b2g-inbound/rev/8da7e59ed88c

Comment 21

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/8da7e59ed88c