1159108 - Assertions for single test need to be factored out as a utility method in selftest.py

Status: NEW

(Testing :: XPCShell Harness, defect)

Description

[Hiroyuki Ikezoe (:hiro)]

See https://bugzilla.mozilla.org/show_bug.cgi?id=1150822#c11

Comment 1

[Hiroyuki Ikezoe (:hiro)]

Attachment: Proposed patch

Create two new method named assertSingleTestPassed and assertSingleTestFailed, and use these methods as possible.

https://treeherder.mozilla.org/#/jobs?repo=try&revision=b5788123f46b

Comment 2

[(not currently active) Ted Mielczarek]

Comment on attachment 8598459 [details] [diff] [review]
Proposed patch

Review of attachment 8598459 [details] [diff] [review]:
-----------------------------------------------------------------

::: testing/xpcshell/selftest.py
@@ +454,5 @@
> +        self.assertEquals(1, self.x.testCount)
> +        self.assertEquals(0, self.x.passCount)
> +        self.assertEquals(1, self.x.failCount)
> +        self.assertEquals(0, self.x.todoCount)
> +        self.assertNotInLog(TEST_PASS_STRING)

Is there a reason you didn't put `self.assertInLog(TEST_FAIL_STRING)` in here? All the call sites seem to call that.

Comment 3

[(not currently active) Ted Mielczarek]

Also thanks for the patch!