Closed
Bug 1159132
Opened 9 years ago
Closed 9 years ago
B2G RIL: use dun apn only when config ro.tethering.dun_required is set
Categories
(Firefox OS Graveyard :: RIL, defect)
Tracking
(tracking-b2g:backlog, firefox40 fixed)
Tracking | Status | |
---|---|---|
firefox40 | --- | fixed |
People
(Reporter: jessica, Assigned: jessica)
References
Details
Attachments
(2 files)
4.43 KB,
patch
|
edgar
:
review+
|
Details | Diff | Splinter Review |
3.40 KB,
patch
|
edgar
:
review+
|
Details | Diff | Splinter Review |
In bug 1115299, we changed it to: if there is dun apn type (dun network registered), then usb/wifi tethering must use that apn. However, we are concerned that using the "dun" apn when it is not really needed, will cause extra charge to users, so we'll revert the changes in bug 1115299 Part 1 and find a way to run dun test case properly.
Assignee | ||
Comment 1•9 years ago
|
||
Assignee | ||
Comment 2•9 years ago
|
||
Assignee | ||
Updated•9 years ago
|
Assignee: nobody → jjong
Assignee | ||
Comment 4•9 years ago
|
||
Comment on attachment 8600820 [details] [diff] [review] Part 1: use dun apn only when config ro.tethering.dun_required is set. Edgar, may I have your review on this? Thanks!
Attachment #8600820 -
Flags: review?(echen)
Assignee | ||
Updated•9 years ago
|
Attachment #8600821 -
Flags: review?(echen)
Comment 5•9 years ago
|
||
Comment on attachment 8600820 [details] [diff] [review] Part 1: use dun apn only when config ro.tethering.dun_required is set. Review of attachment 8600820 [details] [diff] [review]: ----------------------------------------------------------------- Thank you.
Attachment #8600820 -
Flags: review?(echen) → review+
Updated•9 years ago
|
Attachment #8600821 -
Flags: review?(echen) → review+
Assignee | ||
Comment 6•9 years ago
|
||
Thanks Edgar. try looks good besides from some known failures (XPCShell X2, Mochitest 1 and 20): https://treeherder.mozilla.org/#/jobs?repo=try&revision=192924b18180
Keywords: checkin-needed
https://hg.mozilla.org/integration/b2g-inbound/rev/71960acb8633 https://hg.mozilla.org/integration/b2g-inbound/rev/b086661e0d37
Keywords: checkin-needed
Comment 8•9 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/71960acb8633 https://hg.mozilla.org/mozilla-central/rev/b086661e0d37
Status: NEW → RESOLVED
Closed: 9 years ago
status-firefox40:
--- → fixed
Flags: in-testsuite+
Resolution: --- → FIXED
Target Milestone: --- → 2.2 S12 (15may)
You need to log in
before you can comment on or make changes to this bug.
Description
•