B2G RIL: use dun apn only when config ro.tethering.dun_required is set

RESOLVED FIXED in Firefox 40

Status

RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: jessica, Assigned: jessica)

Tracking

unspecified
2.2 S12 (15may)
ARM
Gonk (Firefox OS)
Dependency tree / graph
Bug Flags:
in-testsuite +

Firefox Tracking Flags

(tracking-b2g:backlog, firefox40 fixed)

Details

Attachments

(2 attachments)

(Assignee)

Description

3 years ago
In bug 1115299, we changed it to: if there is dun apn type (dun network registered), then usb/wifi tethering must use that apn.  However, we are concerned that using the "dun" apn when it is not really needed, will cause extra charge to users, so we'll revert the changes in bug 1115299 Part 1 and find a way to run dun test case properly.
(Assignee)

Comment 1

3 years ago
Created attachment 8600820 [details] [diff] [review]
Part 1: use dun apn only when config ro.tethering.dun_required is set.
(Assignee)

Comment 2

3 years ago
Created attachment 8600821 [details] [diff] [review]
Part 2: set ro.tethering.dun_required when running dun test case.
(Assignee)

Updated

3 years ago
Assignee: nobody → jjong
[Tracking Requested - why for this release]:
tracking-b2g: --- → backlog
(Assignee)

Comment 4

3 years ago
Comment on attachment 8600820 [details] [diff] [review]
Part 1: use dun apn only when config ro.tethering.dun_required is set.

Edgar, may I have your review on this? Thanks!
Attachment #8600820 - Flags: review?(echen)
(Assignee)

Updated

3 years ago
Attachment #8600821 - Flags: review?(echen)

Comment 5

3 years ago
Comment on attachment 8600820 [details] [diff] [review]
Part 1: use dun apn only when config ro.tethering.dun_required is set.

Review of attachment 8600820 [details] [diff] [review]:
-----------------------------------------------------------------

Thank you.
Attachment #8600820 - Flags: review?(echen) → review+

Updated

3 years ago
Attachment #8600821 - Flags: review?(echen) → review+
(Assignee)

Comment 6

3 years ago
Thanks Edgar.

try looks good besides from some known failures (XPCShell X2, Mochitest 1 and 20):
https://treeherder.mozilla.org/#/jobs?repo=try&revision=192924b18180
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/71960acb8633
https://hg.mozilla.org/mozilla-central/rev/b086661e0d37
Status: NEW → RESOLVED
Last Resolved: 3 years ago
status-firefox40: --- → fixed
Flags: in-testsuite+
Resolution: --- → FIXED
Target Milestone: --- → 2.2 S12 (15may)
You need to log in before you can comment on or make changes to this bug.