1159144 - HTMLMediaElement::UpdateInitialMediaSize never calls UpdateMediaSize

Status: RESOLVED FIXED

(Core :: Audio/Video, defect)

Description

[JW Wang [:jwwang] [:jw_wang]]

In the patch of bug 1153686 (https://bugzilla.mozilla.org/page.cgi?id=splinter.html&bug=1153686&attachment=8591564), it says

if (!mMediaInfo.HasVideo()) {

However, when uplifting to inbound (https://hg.mozilla.org/integration/mozilla-inbound/rev/818a69e48d38), it says

if (mMediaInfo.mVideo.mDisplay == nsIntSize(0, 0)) {

Comment 1

[JW Wang [:jwwang] [:jw_wang]]

Attachment: 1159144_fix_UpdateInitialMediaSize.patch

Comment 2

[JW Wang [:jwwang] [:jw_wang]]

Try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=958a6e4ba5e1

Comment 3

[Jean-Yves Avenard [:jya]]

Comment on attachment 8598479 [details] [diff] [review]
1159144_fix_UpdateInitialMediaSize.patch

Review of attachment 8598479 [details] [diff] [review]:
-----------------------------------------------------------------

Doh !

Thank you for that.

I had conflicts when I modified the patches and obviously screwed up when rebasing :(

Comment 4

[JW Wang [:jwwang] [:jw_wang]]

Thanks for the review.

Comment 5

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/4a0bec94fdb7

Comment 6

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/4a0bec94fdb7