Closed Bug 1159268 Opened 9 years ago Closed 8 years ago

Make browser_bug1015721.js work with e10s

Categories

(Firefox :: General, defect)

Product:
Firefox
Component:
General
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
Firefox 47
Tracking Flags:
Tracking Status
e10s + ---
firefox46 --- fixed
firefox47 --- fixed

People

(Reporter: enndeakin, Assigned: dao, Mentored)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

patch
3.79 KB, patch
billm
: review+
Details | Diff | Splinter Review 
For example, for browser_bug1015721.js
Blocks: e10s-tests
tracking-e10s: --- → +
Mentor: enndeakin
Attached patch patch — — Splinter Review 
Assignee: nobody → dao
Status: NEW → ASSIGNED

        Attachment #8725174 -
        Flags: review?(wmccloskey)

    
    

    
  
Comment on attachment 8725174 [details] [diff] [review]
patch

Review of attachment 8725174 [details] [diff] [review]:
-----------------------------------------------------------------

::: browser/base/content/test/general/browser_bug1015721.js
@@ +26,5 @@
>      FullZoomHelper.zoomTest(gTab1, 1, "Initial zoom of tab 1 should be 1");
>      FullZoomHelper.zoomTest(gTab2, 1, "Initial zoom of tab 2 should be 1");
>  
>      let browser1 = gBrowser.getBrowserForTab(gTab1);
> +    yield BrowserTestUtils.synthesizeMouse(null, 10, 10, {

Could you please add synthesizeWheel to BTU? It seems a bit cleaner that way.

        Attachment #8725174 -
        Flags: review?(wmccloskey) → review+

    
    

    
  
(In reply to Bill McCloskey (:billm) from comment #2)
> Comment on attachment 8725174 [details] [diff] [review]
> patch
> 
> Review of attachment 8725174 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> ::: browser/base/content/test/general/browser_bug1015721.js
> @@ +26,5 @@
> >      FullZoomHelper.zoomTest(gTab1, 1, "Initial zoom of tab 1 should be 1");
> >      FullZoomHelper.zoomTest(gTab2, 1, "Initial zoom of tab 2 should be 1");
> >  
> >      let browser1 = gBrowser.getBrowserForTab(gTab1);
> > +    yield BrowserTestUtils.synthesizeMouse(null, 10, 10, {
> 
> Could you please add synthesizeWheel to BTU? It seems a bit cleaner that way.

There's also synthesizeMouseAtCenter and synthesizeMouseAtPoint that should be duplicated for wheel events then. This ends up being quite a bit more cumbersome implementation-wise and as an API user I'm not sure I see the benefit.
Flags: needinfo?(wmccloskey)

    
    

    
  
All right, I guess that's fine. It looks like only a few browser chrome tests use this code.
Flags: needinfo?(wmccloskey)

    
  
Summary: [e10s] Need a synthesizeWheel for content processes → Make browser_bug1015721.js work with e10s

    
  
Component: BrowserTest → General
Product: Testing → Firefox

    
    

    
  
https://hg.mozilla.org/mozilla-central/rev/81091bc7558f
Status: ASSIGNED → RESOLVED
Closed: 8 years ago

          status-firefox47:
          --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 47

    
    

    
  
[bugday-20160323]

Status: RESOLVED,FIXED -> UNVERIFIED

Comments:
STR: Not clear.
Developer specific testing

Component: 
Name 			Firefox
Version 		46.0b4
Build ID 		20160322075646
Update Channel 	        beta
User Agent 		Mozilla/5.0 (Windows NT 6.1; WOW64; rv:46.0) Gecko/20100101 Firefox/46.0
OS                      Windows 7 SP1 x86_64

Expected Results: 
Clear STR for verification.

Actual Results: 
As expected

          You need to log in
          before you can comment on or make changes to this bug.