1159268 - Make browser_bug1015721.js work with e10s

Status: RESOLVED FIXED

(Firefox :: General, defect)

Description

[Neil Deakin]

For example, for browser_bug1015721.js

Comment 1

[Dão Gottwald [:dao]]

Attachment: patch

Comment 2

[Bill McCloskey [inactive unless it's an emergency] (:billm)]

Comment on attachment 8725174 [details] [diff] [review]
patch

Review of attachment 8725174 [details] [diff] [review]:
-----------------------------------------------------------------

::: browser/base/content/test/general/browser_bug1015721.js
@@ +26,5 @@
>      FullZoomHelper.zoomTest(gTab1, 1, "Initial zoom of tab 1 should be 1");
>      FullZoomHelper.zoomTest(gTab2, 1, "Initial zoom of tab 2 should be 1");
>  
>      let browser1 = gBrowser.getBrowserForTab(gTab1);
> +    yield BrowserTestUtils.synthesizeMouse(null, 10, 10, {

Could you please add synthesizeWheel to BTU? It seems a bit cleaner that way.

Comment 3

[Dão Gottwald [:dao]]

(In reply to Bill McCloskey (:billm) from comment #2)
> Comment on attachment 8725174 [details] [diff] [review]
> patch
> 
> Review of attachment 8725174 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> ::: browser/base/content/test/general/browser_bug1015721.js
> @@ +26,5 @@
> >      FullZoomHelper.zoomTest(gTab1, 1, "Initial zoom of tab 1 should be 1");
> >      FullZoomHelper.zoomTest(gTab2, 1, "Initial zoom of tab 2 should be 1");
> >  
> >      let browser1 = gBrowser.getBrowserForTab(gTab1);
> > +    yield BrowserTestUtils.synthesizeMouse(null, 10, 10, {
> 
> Could you please add synthesizeWheel to BTU? It seems a bit cleaner that way.

There's also synthesizeMouseAtCenter and synthesizeMouseAtPoint that should be duplicated for wheel events then. This ends up being quite a bit more cumbersome implementation-wise and as an API user I'm not sure I see the benefit.

Comment 4

[Bill McCloskey [inactive unless it's an emergency] (:billm)]

All right, I guess that's fine. It looks like only a few browser chrome tests use this code.

Comment 5

[Pulsebot]

https://hg.mozilla.org/integration/fx-team/rev/81091bc7558f

Comment 6

[Dão Gottwald [:dao]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/5118c15e69fd

Comment 7

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/81091bc7558f

Comment 8

[Mayur Patil]

[bugday-20160323]

Status: RESOLVED,FIXED -> UNVERIFIED

Comments:
STR: Not clear.
Developer specific testing

Component: 
Name 			Firefox
Version 		46.0b4
Build ID 		20160322075646
Update Channel 	        beta
User Agent 		Mozilla/5.0 (Windows NT 6.1; WOW64; rv:46.0) Gecko/20100101 Firefox/46.0
OS                      Windows 7 SP1 x86_64

Expected Results: 
Clear STR for verification.

Actual Results: 
As expected