1159346 - rss feeds appear as empty folders

Status: VERIFIED FIXED

(Firefox :: Bookmarks & History, defect)

Description

[Dana Keeler (she/her) (use needinfo) [:keeler]]

I (used to) have a number of bookmarked RSS feeds. Today after updating to the latest nightly, they were turned into empty directories. Furthermore, I can't add any new RSS feeds (when viewing a feed, the "subscribe now" button does nothing).

Comment 1

[Dana Keeler (she/her) (use needinfo) [:keeler]]

It appears that the "subscribe now" button not working is e10s-related. However, even after viewing a feed in a non-e10s window and successfully clicking "subscribe now", the feed doesn't appear anywhere in my bookmarks.

Comment 2

[Marco Bonardo [:mak]]

I see the same, it's not e10s related.
Looks like a regression in bookmarks, I will investigate it later.

Comment 4

[Marco Bonardo [:mak]]

Attachment: patch v1

I should have added a test when you told me to :/

Comment 5

[Pulsebot]

https://hg.mozilla.org/integration/fx-team/rev/d8590ff0898f

Comment 7

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/d8590ff0898f

Comment 8

[Cornel Ionce [:noni] [Hubs QA]]

This seems to be only fixed on Mac OS X, using latest Nightly, build ID: 20150503030209.

On Windows 7 64-bit, Windows 8.1 64-bit and Ubuntu 14.04 64-bit, the user can now view the existing feeds but it's unable to add new ones.

After clicking "subscribe now", nothing happens and the following console errors are thrown:
NS_ERROR_NOT_AVAILABLE: Component returned failure code: 0x80040111 (NS_ERROR_NOT_AVAILABLE) [nsIPrefBranch.setCharPref] FeedWriter.js:1275:0

Comment 9

[Marco Bonardo [:mak]]

(In reply to Cornel Ionce [QA] from comment #8)
> On Windows 7 64-bit, Windows 8.1 64-bit and Ubuntu 14.04 64-bit, the user
> can now view the existing feeds but it's unable to add new ones.
> 
> After clicking "subscribe now", nothing happens and the following console
> errors are thrown:
> NS_ERROR_NOT_AVAILABLE: Component returned failure code: 0x80040111
> (NS_ERROR_NOT_AVAILABLE) [nsIPrefBranch.setCharPref] FeedWriter.js:1275:0

This bug is only about broken existing livemarks... if there's a bug in adding livemarks, it's somewhere else, for example it might be an e10s issue:

https://bugzilla.mozilla.org/buglist.cgi?quicksearch=feed%20e10s&list_id=12227754

Indeed it works properly in a non-e10s window...

Comment 10

[Marco Bonardo [:mak]]

so basically, comment 1 here has nothing to do with comment 0... it needs a separate bug, but might be one of the known e10s bugs already.

Comment 11

[Marco Bonardo [:mak]]

let me clarify the title.

Comment 12

[Marco Bonardo [:mak]]

note that I currently cannot find an explicit bug about subscribe to feed being broken on e10s, the bugs above look like minor downsides.
Could be bug 1109714, so I'd suggest to ask there and eventually file a separate bug if needed.

Comment 13

[Cornel Ionce [:noni] [Hubs QA]]

Yup, that indeed seems to be bug 1109714, as the subscribe button is not working on e10s and the UI will be changed.
Thanks for clarifying this!