1159348 - Build Warning: The app icon set "AppIcon" has unassigned images

Status: RESOLVED FIXED

(Firefox for iOS :: General, defect)

Description

[Aaron Train [:aaronmt]]

We should fill in the missing iPhone/iPad spotlight/settings if need be, otherwise just wontfix this bug

Comment 1

[Aaron Train [:aaronmt]]

Whoops, it's icon-60.png that's unassigned

Comment 2

[Stefan Arentz | :st3fan | ⏰ EST | he/him]

I resolved all these Unassigned Images warnings by removing images from the assets that are not .. assigned.

This resulted in the following images to be removed:

	deleted:    Client/Assets/Images.xcassets/AppIcon.appiconset/Icon-60.png
	deleted:    Client/Assets/Images.xcassets/backPressed.imageset/Back-arrow (Pressed).png
	deleted:    Client/Assets/Images.xcassets/backPressed.imageset/Back-arrow (Pressed)@2x.png
	deleted:    Client/Assets/Images.xcassets/backPressed.imageset/Back-arrow (Pressed)@3x.png
	deleted:    Client/Assets/Images.xcassets/deviceTypeDesktop.imageset/pc-iOS.png
	deleted:    Client/Assets/Images.xcassets/deviceTypeDesktop.imageset/[e-mail]
	deleted:    Client/Assets/Images.xcassets/deviceTypeDesktop.imageset/[e-mail]
	deleted:    Client/Assets/Images.xcassets/deviceTypeMobile.imageset/mobile-iOS.png
	deleted:    Client/Assets/Images.xcassets/deviceTypeMobile.imageset/[e-mail]
	deleted:    Client/Assets/Images.xcassets/deviceTypeMobile.imageset/[e-mail]
	deleted:    Client/Assets/Images.xcassets/reader.imageset/readerOff.png
	deleted:    Client/Assets/Images.xcassets/reader.imageset/[e-mail]
	deleted:    Client/Assets/Images.xcassets/reader.imageset/[e-mail]
	deleted:    Client/Assets/Images.xcassets/reader_active.imageset/readerOn.png
	deleted:    Client/Assets/Images.xcassets/reader_active.imageset/[e-mail]
	deleted:    Client/Assets/Images.xcassets/reader_active.imageset/[e-mail]
	deleted:    Client/Assets/Images.xcassets/sendPressed.imageset/Export (Pressed).png
	deleted:    Client/Assets/Images.xcassets/sendPressed.imageset/Export (Pressed)@2x.png
	deleted:    Client/Assets/Images.xcassets/sendPressed.imageset/Export (Pressed)@3x.png
	deleted:    Client/Frontend/Home/Home.xcassets/panelIconBookmarksSelected.imageset/Bookmarks (pressed).png
	deleted:    Client/Frontend/Home/Home.xcassets/panelIconBookmarksSelected.imageset/Bookmarks (pressed)@2x.png
	deleted:    Client/Frontend/Home/Home.xcassets/panelIconBookmarksSelected.imageset/Bookmarks (pressed)@3x.png
	deleted:    Client/Frontend/Home/Home.xcassets/panelIconHistorySelected.imageset/History panel (pressed).png
	deleted:    Client/Frontend/Home/Home.xcassets/panelIconHistorySelected.imageset/History panel (pressed)@2x.png
	deleted:    Client/Frontend/Home/Home.xcassets/panelIconHistorySelected.imageset/History panel (pressed)@3x.png
	deleted:    Client/Frontend/Home/Home.xcassets/panelIconReadingListSelected.imageset/Reading List (selected)@2x.png
	deleted:    Client/Frontend/Home/Home.xcassets/panelIconReadingListSelected.imageset/Reading List (selected)@3x.png
	deleted:    Client/Frontend/Home/Home.xcassets/panelIconSyncedTabsSelected.imageset/Synced Panel 2 (selected).png
	deleted:    Client/Frontend/Home/Home.xcassets/panelIconSyncedTabsSelected.imageset/Synced Panel 2 (selected)@2x.png
	deleted:    Client/Frontend/Home/Home.xcassets/panelIconSyncedTabsSelected.imageset/Synced Panel 2 (selected)@3x.png
	deleted:    Extensions/ShareTo/Images.xcassets/AddToBookmarks.imageset/AddToBookmarks.png
	deleted:    Extensions/ShareTo/Images.xcassets/AddToBookmarks.imageset/[e-mail]
	deleted:    Extensions/ShareTo/Images.xcassets/AddToReadingList.imageset/AddToReadingList.png
	deleted:    Extensions/ShareTo/Images.xcassets/AddToReadingList.imageset/[e-mail]
	deleted:    Extensions/ShareTo/Images.xcassets/AddToReadingList.imageset/[e-mail]
	deleted:    Extensions/ShareTo/Images.xcassets/Icon-Small.imageset/Icon-Small.png
	deleted:    Extensions/ShareTo/Images.xcassets/Icon-Small.imageset/[e-mail]
	deleted:    Extensions/ShareTo/Images.xcassets/Icon-Small.imageset/[e-mail]

Before I commit this, Robin, I think we either not use these or they have been replaced with newer versions. Can you verify?

Comment 3

[Robin Andersen [:tecgirl]]

From glancing at the naming conventions and the Universal assignments, these look OK to remove.

Comment 4

[Stephan Leroux [:sleroux]]

Attachment: PR https://github.com/mozilla/firefox-ios/pull/777

Comment 5

[Stephan Leroux [:sleroux]]

Merged.