1159375 - Disable Angular's debug info for improved performance

Status: RESOLVED FIXED

(Tree Management :: Treeherder, defect, P2)

Description

[Ed Morley [:emorley]]

See:
http://blog.thoughtram.io/angularjs/2014/12/22/exploring-angular-1.3-disabling-debug-info.html

Comment 1

[Ed Morley [:emorley]]

Attachment: Disable Angular's debug data

Comment 2

[William Lachance (:wlach)]

Comment on attachment 8613313 [details] [review]
Disable Angular's debug data

Looks fine, I wonder what kind of performance impact this would have, if any. I don't think our bottlenecks are really in angular, for the most part.

You might want to update the logviewer (logviewer.js) to use this as well.

Comment 3

[Treeherder GitHub Bugbot]

Commit pushed to master at https://github.com/mozilla/treeherder

https://github.com/mozilla/treeherder/commit/5966bbc5602773c75c6324b0d6500616338bbf89
Bug 1159375 - Disable Angular's debug data to improve perf

As recommended by:
https://docs.angularjs.org/guide/production
http://blog.thoughtram.io/angularjs/2014/12/22/exploring-angular-1.3-disabling-debug-info.html

The debug data can be repopulated on the fly using:
angular.reloadWithDebugInfo();
...from the console.

Comment 4

[Ed Morley [:emorley]]

(In reply to William Lachance (:wlach) from comment #2)
> You might want to update the logviewer (logviewer.js) to use this as well.

Ah indeed; done :-)