Closed Bug 1159376 Opened 5 years ago Closed 5 years ago

[Customizer] Update to use 'import-app' activity

Categories

(Firefox OS Graveyard :: Gaia::Customizer, defect, P1)

Product:
Firefox OS Graveyard
Component:
Gaia::Customizer
Platform:
ARM
Gonk (Firefox OS)
Type:
defect

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: justindarc, Assigned: justindarc)

References

Details

(Whiteboard: [spark])

Attachments

(1 file)

pull-request (master)
42 bytes, text/x-github-pull-request
drs
: review+
Details | Review 
Instead of directly invoking `navigator.mozApps.mgmt.import()`, the Customizer should invoke the 'import-app' activity to work around permissions issues.
Assignee: nobody → jdarcangelo
Priority: -- → P1
Whiteboard: [spark]
See Also: → 1158238
Just FYI that bug 1158238 initially landed with the activity being named 'import' instead of 'import-app'. I'm going to land a fix today to rename it to `import-app`, hope that doens't cause you any issues.
(In reply to Kevin Grandon :kgrandon from comment #1)
> Just FYI that bug 1158238 initially landed with the activity being named
> 'import' instead of 'import-app'. I'm going to land a fix today to rename it
> to `import-app`, hope that doens't cause you any issues.

Ah, good catch. Thanks. Probably not getting around to this today anyway since we're still on the lightsaber gaia branch.
Depends on: 1161748
Attached file pull-request (master) —
Attachment #8608939 - Flags: review?(drs)
Blocks: 1167342
Attachment #8608939 - Flags: review?(drs) → review+
Landed on master:

https://github.com/fxos/customizer/commit/c2dcce71b5a8e9fb9bbd3535b785c06048e4bdb5
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.