1159430 - Remove b2g emulator return code hack for Nuwa tests

Status: RESOLVED WONTFIX

(Release Engineering :: Applications: MozharnessCore, defect)

Description

[Andrew Halberstadt [:ahal]]

We put a hack into mozharness to hide a perma-failure that has since been fixed:
https://dxr.mozilla.org/build:mozharness/source/scripts/b2g_emulator_unittest.py#348

We should remove it. The fix (bug 1142229) is on central and the b2g release branches, so we'd need to land it on the remaining release branches before removing that code. Alternatively I could blacklist the remaining release branches until the fix has propagated.

Comment 1

[Andrew Halberstadt [:ahal]]

Oh I forgot that aurora/beta/release don't run emulator jobs. I think that means the fix is already everywhere it needs to be.

Comment 2

[Andrew Halberstadt [:ahal]]

Attachment: MozReview Request: bz://1159430/ahal

/r/7803 - Bug 1159430 - Remove b2g emulator success codes hack for since fixed Nuwa tests, r=chmanchester

Pull down this commit:

hg pull -r 1ebc4aa0e4457f08c06f2c58c6b4506e2c66046f https://reviewboard-hg.mozilla.org/build-mozharness

Comment 3

[Chris Manchester (limited bugmail, email directly)]

Comment on attachment 8598886 [details]
MozReview Request: bz://1159430/ahal

https://reviewboard.mozilla.org/r/7801/#review6601

Ship It!

Comment 4

[Andrew Halberstadt [:ahal]]

This looks good on try:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=d5bb68816ac6

But it's hard to test out the older release branches. RyanVM says that the fix from bug 1142229 has landed on all the required b2g branches, but it's possible a different failure that was getting hidden by this hack could pop up on one of them. We'll just have to keep an eye on them when this gets merged.

Comment 5

[Ryan VanderMeulen [:RyanVM]]

Debug M11 on that push is depressing.

Comment 6

[Andrew Halberstadt [:ahal]]

Ugh :(.

Unrelated since the return code is 0, but yes, depressing.

Comment 7

[Andrew Halberstadt [:ahal]]

Comment on attachment 8598886 [details]
MozReview Request: bz://1159430/ahal

https://hg.mozilla.org/build/mozharness/rev/081ee7893122

Comment 8

[Ryan VanderMeulen [:RyanVM]]

(In reply to Andrew Halberstadt [:ahal] from comment #7)
> https://hg.mozilla.org/build/mozharness/rev/081ee7893122

And on the mozilla-b2g37_v2_2 branch:
https://hg.mozilla.org/build/mozharness/rev/9de394bc9f11

I've got Try pushes going to make sure there are no surprises before updating the in-tree pointers.

Comment 9

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-b2g37_v2_2/rev/e4121e6afbc7
https://hg.mozilla.org/releases/mozilla-b2g34_v2_1/rev/b5d2472c2940
https://hg.mozilla.org/releases/mozilla-b2g32_v2_0/rev/9e3136b90c12

Comment 10

[Rail Aliiev [:rail]]

mozharness production tag moved to: https://hg.mozilla.org/build/mozharness/rev/ca580fcfa627

Comment 11

[Vincent Liu[:vliu]]

https://hg.mozilla.org/releases/mozilla-b2g34_v2_1s/rev/b5d2472c2940

Comment 12

[Rail Aliiev [:rail]]

mozharness production tag moved to: https://hg.mozilla.org/build/mozharness/rev/4d260376921f

Comment 14

[Andrew Halberstadt [:ahal]]

Attachment: MozReview Request: Bug 1159430 - Remove b2g emulator success codes hack for since fixed Nuwa tests, r=chmanchester

Comment 15

[Jan Beich]

Nuwa is gone after bug 1284674.