Closed
Bug 1159459
Opened 9 years ago
Closed 8 years ago
Lots of time dealing with scrollframes after treeherder layout
Categories
(Core :: Layout, defect)
Core
Layout
Tracking
()
RESOLVED
WORKSFORME
Tracking | Status | |
---|---|---|
firefox40 | --- | affected |
People
(Reporter: bzbarsky, Unassigned)
References
Details
Attachments
(1 file)
4.44 KB,
patch
|
Details | Diff | Splinter Review |
STEPS TO REPRODUCE: 1) Load http://treeherder.mozilla.org/ 2) Scroll down to the bottom. 3) Click the "50" button to load more results. 4) Open the web console. 5) Run this script: document.documentElement.style.display = "none"; document.body.offsetWidth; var start = new Date; document.documentElement.style.display = ""; getComputedStyle(document.documentElement).color; var mid = new Date; document.body.offsetWidth; console.log("Style: " + (mid - start) + "\nLayout: " + (new Date - mid)); We spend a lot of time on layout here. I profiled it, and 20% of the time under ProcessReflowCommands is actually spent under DidDoReflow, calling ScrollFrameHelper::ReflowFinished. Some of this is then FinishReflowForScrollbar, but most is ScrollToImpl, which is all under GetPaintedLayerScaleForFrame. Mostly the hashtable lookup, with a bit of GetTransformToAncestor calling GetTransformMatrix.
Flags: needinfo?(roc)
Flags: needinfo?(roc)
Reporter | ||
Comment 1•8 years ago
|
||
Timothy, do you know anything about the scrollframe stuff above?
Flags: needinfo?(tnikkel)
Comment 2•8 years ago
|
||
I wrote a patch that reduces the number of GetPaintedLayerScaleForFrame calls from ~130 to 1 for your testcase, but it had no noticeable affect on the runtime. In profiling (without my patch) I couldn't find GetPaintedLayerScaleForFrame at all. Do you want to re-do your profiling? Maybe treeherder changed? Or maybe our code changed?
Flags: needinfo?(tnikkel) → needinfo?(bzbarsky)
Reporter | ||
Comment 3•8 years ago
|
||
Hmm. Yeah, something must have changed; I'm not seeing this anymore...
Status: NEW → RESOLVED
Closed: 8 years ago
Flags: needinfo?(bzbarsky)
Resolution: --- → WORKSFORME
Comment 4•8 years ago
|
||
Here's the patch I was using in case it's useful in the future.
I think the underlying performance problem here is still present; see bug 1363919.
... or maybe *increased* with bug 1012752, which I now realize landed *after* this bug happened.
You need to log in
before you can comment on or make changes to this bug.
Description
•