Closed Bug 1159465 Opened 9 years ago Closed 9 years ago

Always make cross-compartment assertions for Object->Object edges

Categories

(Core :: JavaScript: GC, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla40
Tracking Status
firefox40 --- fixed

People

(Reporter: terrence, Assigned: terrence)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

We appear to have this assertion in the most common traversal path. This patch moves that assertion into traverse to tighten the check for all object->object from zone to compartment and to simplify processMarkStackTop some.
Attachment #8598918 - Flags: review?(jcoppeard)
Comment on attachment 8598918 [details] [diff] [review]
12_add_compartment_assertions_for_objects-v0.diff

Review of attachment 8598918 [details] [diff] [review]:
-----------------------------------------------------------------

Yes, good idea.
Attachment #8598918 - Flags: review?(jcoppeard) → review+
https://hg.mozilla.org/mozilla-central/rev/bcbd4118f341
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla40
You need to log in before you can comment on or make changes to this bug.