1159491 - [RTL] [Settings] - The arrow indicating additional sub-menus does not get reversed in the Built-in Keyboard menu causing it to overlap with 'User dictionary'

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::Keyboard, defect, P1)

Description

[Joshua Mitchell (Inactive)]

Attachment: WrongWayArrow.png

Description:
 In RTL, the arrow should be moved from the right side to the left but it is not. The words User dictionary overlaps it making it very difficult to see

Repro Steps: In an RTL language
1) Update a Flame to 20150428010206
2) Launch Settings App
3) Select Keyboard, and select 'Built-in Keyboard'


Actual:
> arrow indicating additional sub-menus is not properly flipped to the left side of the screen

Expected:
arrow will be moved to the left side, not overlap words


Environmental Variables:
Device: Flame 3.0 (KK - Nightly - Full Flash - 319mem)
Build ID: 20150428010206
Gaia: 0636405f0844bf32451a375b2d61a2b16fe33348
Gecko: caf25344f73e
Gonk: b83fc73de7b64594cd74b33e498bf08332b5d87b
Version: 40.0a1 (3.0)
Firmware Version: v18D-1
User Agent: Mozilla/5.0 (Mobile; rv:40.0) Gecko/40.0 Firefox/40.0


Repro frequency: 5/5
See attached: screenshot

Comment 1

[Joshua Mitchell (Inactive)]

Feature is not present prior to 3.0

Comment 2

[Delphine Lebédel [:delphine - OOO]]

Assigning Priority to get this out of 2.2 triage query
Triage: P1. But Not nominating as I'm not sure what 3.0 RTL specs should be

Comment 3

[Shine(Leave from Mozilla)]

Attachment: Flame3.0&N53.0.png

Hi William,
This Problem can be reproduced on latest Flame3.0 and N5 3.0 build (The "User dictionary" string in Arabic language is different form that in previous version, but the arrow still show at right side and not mirrored.) Could you have someone to help with this bug? Many thanks!
See attachment: Flame3.0&N53.0.png
Rate：5/5

Note: On Flame 2.2 and N5 2.2, there's no "User dictionary" item on "Built-in Keyboard" screen.

Device information:
Flame 3.0 Build ID: 20150526160204
Nexus5 3.0 Build ID: 20150526160204

Comment 4

[William Hsu [:whsu]]

[Blocking Requested - why for this release]:

(In reply to Shine from comment #3)
> Created attachment 8611094 [details]
> Flame3.0&N53.0.png
> 
> Hi William,
> This Problem can be reproduced on latest Flame3.0 and N5 3.0 build (The
> "User dictionary" string in Arabic language is different form that in
> previous version, but the arrow still show at right side and not mirrored.)
> Could you have someone to help with this bug? Many thanks!
> See attachment: Flame3.0&N53.0.png
> Rate：5/5
> 
> Note: On Flame 2.2 and N5 2.2, there's no "User dictionary" item on
> "Built-in Keyboard" screen.
> 
> Device information:
> Flame 3.0 Build ID: 20150526160204
> Nexus5 3.0 Build ID: 20150526160204

Hi, Shine,

Thank you.

This is a v3.0 new feature (Bug 1029951).
Delphine and I are not sure what 3.0 RTL specs should be.
Let's keep tracking it.

Comment 5

[Shine(Leave from Mozilla)]

OK, thanks William.

Comment 6

[[e-mail]]

Attachment: buildin.png

arrow aligned left after patch

Comment 7

[GitHub Autolander Bot]

Attachment: [gaia] gasolin:issue-1159491 > mozilla-b2g:master

Comment 8

[[e-mail]]

Comment on attachment 8635896 [details] [review]
[gaia] gasolin:issue-1159491 > mozilla-b2g:master

fix RTL arrow link in keyboard > build-in keyboard > user dictionary >

Comment 9

[Tim Guan-tin Chien [:timdream] (please needinfo)]

Comment on attachment 8635896 [details] [review]
[gaia] gasolin:issue-1159491 > mozilla-b2g:master

We should migrate everything to Components in the future right?

Comment 10

[[e-mail]]

Yes, though we still needs do some make up to fix this kind of issues at present, we would wrap these into components after careful measurements to avoid loadtime regression. 

merged https://github.com/mozilla-b2g/gaia/commit/c99fd7090e0f6ce0bea241702c5b16756b45ab55

thanks!

Comment 11

[Shine(Leave from Mozilla)]

Attachment: Flame_master_verify2.png

This problem is verified as "pass" on latest build of Flame master and N5 master by the STR in comment 0.
Actual result: The arrow is left-aligned and not mirrored in RTL mode.
See attachment: Flame_master_verify2.png
Rate: 0/10

Device information:
Flame master (Pass)
Build ID               20150721160205
Gaia Revision          84c3bf622e211046d905803b34de5d331761f22d
Gaia Date              2015-07-21 16:28:35
Gecko Revision         https://hg.mozilla.org/mozilla-central/rev/1875a5584e5f
Gecko Version          42.0a1
Device Name            flame
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.cltbld.20150721.194129
Firmware Date          Tue Jul 21 19:41:42 EDT 2015
Bootloader             L1TC000118D0

N5 master (Pass)
Build ID               20150721160205
Gaia Revision          84c3bf622e211046d905803b34de5d331761f22d
Gaia Date              2015-07-21 16:28:35
Gecko Revision         https://hg.mozilla.org/mozilla-central/rev/1875a5584e5f
Gecko Version          42.0a1
Device Name            hammerhead
Firmware(Release)      5.1
Firmware(Incremental)  eng.cltbld.20150721.211608
Firmware Date          Tue Jul 21 21:16:23 EDT 2015
Bootloader             HHZ12f