1159552 - [bluetooth2] Clear local {services|characteristics|descriptors} arrays when handling discovering procedures.

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Bluetooth, defect)

Description

[Bruce Sun [:brsun]]

|BluetoothGatt.services| [1] has duplicated services if |BluetoothGatt.discoverServices()| [2] is called more than once.

|BluetoothGatt.mServices| might need to be cleared in |BluetoothGatt::HandleServicesDiscovered()| [3] in Gecko.


[1] https://wiki.mozilla.org/B2G/Bluetooth/WebBluetooth-v2/BluetoothGatt#discoverServices.28.29
[2] https://wiki.mozilla.org/B2G/Bluetooth/WebBluetooth-v2/BluetoothGatt#services
[3] https://dxr.mozilla.org/mozilla-central/source/dom/bluetooth/bluetooth2/BluetoothGatt.cpp#279

Comment 1

[Bruce Sun [:brsun]]

|BluetoothGattService.characteristics| [1][2] and |BluetoothGattCharacteristic.descriptors| [3] have similar issues.

[1] https://bugzilla.mozilla.org/show_bug.cgi?id=1159555
[2] https://wiki.mozilla.org/B2G/Bluetooth/WebBluetooth-v2/BluetoothGattService#characteristics
[3] https://wiki.mozilla.org/B2G/Bluetooth/WebBluetooth-v2/BluetoothGattCharacteristic#descriptors

Comment 3

[Bruce Sun [:brsun]]

Attachment: bug1159552_gatt_clear_local_arrays_while_discovering.patch

Comment 4

[Jocelyn Liu [:jocelyn] [:joliu]]

Comment on attachment 8599292 [details] [diff] [review]
bug1159552_gatt_clear_local_arrays_while_discovering.patch

Review of attachment 8599292 [details] [diff] [review]:
-----------------------------------------------------------------

LGTM.

Thanks for fixing this bug!

Comment 5

[Bruce Sun [:brsun]]

Attachment: bug1159552_gatt_clear_local_arrays_while_discovering.commit.patch

Try results seem good: https://treeherder.mozilla.org/#/jobs?repo=try&revision=ec2f1a42ed2a

Comment 6

[Pulsebot]

https://hg.mozilla.org/integration/b2g-inbound/rev/5e40e02cb872

Comment 7

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/5e40e02cb872