1159561 - Rework history storage to support syncing: initial cleanup

Status: RESOLVED FIXED

(Firefox for iOS :: Data Storage, defect)

Comment 1

[Richard Newman [:rnewman]]

Attachment: Pull request.

The `Deferred` switch was way cleaner than I expected!

Whichever of you gets to this first wins. Go! :D

Comment 2

[Nick Alexander :nalexander [he/him] (PTO August 1-10)]

Comment on attachment 8599064 [details] [review]
Pull request.

In general, I'm fine with this -- questions oand comments on GH.  However, I do not understand (and haven't read the further sync stuff /to/ understand) what the desired Visit/SiteVisit/something else split is.  I find that confusing and unexpected and suggest wesj weigh in tomorrow and I'll loop back as well.

Comment 3

[Richard Newman [:rnewman]]

I commented in the PR, but in short: `SiteVisit` is what the frontend code was already consuming, just with a different name. `Visit` is the simpler 'root' that Sync will produce.

This is effectively the alternative to the `RemoteTab`/`Tab` issue that you commented on in tab sync, and it'll get resolved (likely to the point of just killing `SiteVisit` altogether) as I move forward with syncing and rip out the existing history storage and UI-facing bits. After all, we don't show visits in the UI…

Comment 4

[Richard Newman [:rnewman]]

I suspect we'll run into this "annotated version" (anti?)-pattern a few times: that is, we have these domain objects that end up being decorated with row IDs, foreign key references, etc.

IMO that'll frequently often be a sign that there's "model-view-controller smear" going on: rather than the model exposing domain items and what the UI wants (e.g., URLs and titles by frecency) it exposes the database contents (a cursor of objects containing row IDs).

That viewpoint is why I expect SiteVisit to die -- the reference from a visit to a site is an implementation detail of the database schema.

Comment 5

[Richard Newman [:rnewman]]

(In reply to Richard Newman [:rnewman] from comment #4)
> frequently often…

frequently often sometimes always.

This is how my brain works when I wake up at 4:30am.

Comment 6

[Stefan Arentz | :st3fan | ⏰ EST | he/him]

Comment on attachment 8599064 [details] [review]
Pull request.

Love the new Deferred style vs blocks.

Comment 7

[Richard Newman [:rnewman]]

https://github.com/mozilla/firefox-ios/commit/26bb5088ba94667753d9f0ebbe3d9127e1149b0f

Comment 8

[Wesley Johnston (:wesj)]

rnewman, can you ping me on this stuff in the future? I wrote this stuff. I like to keep some tabs on changes in it...

Comment 9

[Wesley Johnston (:wesj)]

Oh you did! I just got removed....