Closed
Bug 1159578
Opened 10 years ago
Closed 10 years ago
Have TimeUnit object
Categories
(Core :: Audio/Video, defect)
Core
Audio/Video
Tracking
()
RESOLVED
FIXED
mozilla40
| Tracking | Status | |
|---|---|---|
| firefox40 | --- | fixed |
People
(Reporter: jya, Assigned: jya)
References
Details
Attachments
(1 file, 1 obsolete file)
|
2.90 KB,
patch
|
mattwoodrow
:
review+
|
Details | Diff | Splinter Review |
Bug 1138260 introduced the strongly typed media::Microseconds object. The main aim of this type was to avoid common bugs comparing seconds with microseconds and incorrectly use them interchangeably.
We should have a TimeUnit object which doesn't represent a particular time unit, but instead would be used to convert to microseconds or seconds or what else.
The internal implementation of a TimeUnit would likely use microseconds.
|
Assignee | |
Updated•10 years ago
|
Assignee: nobody → jyavenard
|
|
Assignee | |
Comment 1•10 years ago
|
||
Add TimeUnit object, a strongly typed unit of time
Attachment #8599640 -
Flags: review?(matt.woodrow)
|
|
Assignee | |
Comment 2•10 years ago
|
||
Comment on attachment 8599640 [details] [diff] [review]
Add a TimeUnit object
will change so it can detect overflow
Attachment #8599640 -
Attachment is obsolete: true
Attachment #8599640 -
Flags: review?(matt.woodrow)
|
|
Assignee | |
Comment 3•10 years ago
|
||
Use CheckedInt64 instead
Attachment #8600142 -
Flags: review?(matt.woodrow)
|
||
Updated•10 years ago
|
Attachment #8600142 -
Flags: review?(matt.woodrow) → review+
|
||
Comment 5•10 years ago
|
||
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla40
You need to log in
before you can comment on or make changes to this bug.
Description
•