[bluetooth2] Remove incorrect value assertion in BluetoothGattCharacteristic and BluetoothGattDescriptor

RESOLVED FIXED in Firefox 40

Status

defect
RESOLVED FIXED
4 years ago
4 years ago

People

(Reporter: yrliou, Assigned: yrliou)

Tracking

unspecified
2.2 S11 (1may)
Dependency tree / graph

Firefox Tracking Flags

(firefox40 fixed)

Details

(Whiteboard: [webbt-api])

Attachments

(1 attachment, 1 obsolete attachment)

We will hit assertions in |BluetoothGattCharacteristic::GetValue| and
|BluetoothGattDescriptor::GetValue| while running on debug build.

In these functions, we do MOZ_ASSERT(aValue).
It's actually checking MutableHandle::ptr which is still null and will be set later in this function.
Comment on attachment 8599202 [details] [diff] [review]
Bug 1159650 - Remove incorrect value assertions in BluetoothGattCharacteristic and BluetoothGattDescriptor.

Review of attachment 8599202 [details] [diff] [review]:
-----------------------------------------------------------------

LGTM.
Attachment #8599202 - Flags: review?(btian) → review+
No try server result since the change is only in bluetooth2 and won't be built on try server.
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/df6cfb090e06
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → 2.2 S11 (1may)
You need to log in before you can comment on or make changes to this bug.