1159650 - [bluetooth2] Remove incorrect value assertion in BluetoothGattCharacteristic and BluetoothGattDescriptor

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Bluetooth, defect)

Description

[Jocelyn Liu [:jocelyn] [:joliu]]

We will hit assertions in |BluetoothGattCharacteristic::GetValue| and
|BluetoothGattDescriptor::GetValue| while running on debug build.

In these functions, we do MOZ_ASSERT(aValue).
It's actually checking MutableHandle::ptr which is still null and will be set later in this function.

Comment 1

[Jocelyn Liu [:jocelyn] [:joliu]]

Attachment: Bug 1159650 - Remove incorrect value assertions in BluetoothGattCharacteristic and BluetoothGattDescriptor.

Comment 2

[Ben Tian (inactive)]

Comment on attachment 8599202 [details] [diff] [review]
Bug 1159650 - Remove incorrect value assertions in BluetoothGattCharacteristic and BluetoothGattDescriptor.

Review of attachment 8599202 [details] [diff] [review]:
-----------------------------------------------------------------

LGTM.

Comment 3

[Jocelyn Liu [:jocelyn] [:joliu]]

Attachment: [Final] Bug 1159650 - Remove incorrect value assertions in BluetoothGattCharacteristic and BluetoothGattDescriptor. r=btian

Thanks for your time, Ben.

Comment 4

[Jocelyn Liu [:jocelyn] [:joliu]]

No try server result since the change is only in bluetooth2 and won't be built on try server.

Comment 5

[Pulsebot]

https://hg.mozilla.org/integration/b2g-inbound/rev/df6cfb090e06

Comment 6

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/df6cfb090e06