Closed Bug 1159696 Opened 4 years ago Closed 4 years ago
Space between doorhanger and URL Bar on v11 tablets
Steps to reproduce: 1. Go to: http://people.mozilla.org/~mleibovic/test/geo.html 2. Scroll down to the "Request location" button and tap it. Expected results: - A doorhanger is correctly displayed under the URL Bar, under the Back button Actual results: - The doorhanger is not fixed to the URL Bar. There is a space between it and the URL Bar Note: - The doorhanger is correctly displayed when disabling "Full-screen browsing" - regression from Bug 1151505- Doorhanger can appear while browser toolbar is scrolled off screen
What device is this? I've been testing on a Nexus 7 and a Nexus 9, and I can't repro this problem. I'll try this on some other devices to see if I can repro.
I have reproduced the issue using Asus Transformer (Android 4.0.3)
This is a regression from bug 1151505. I didn't account for v11 tablets having their system bar on the bottom, while on v16 devices, the system bar is on the top.
Summary: Space between doorhanger and URL Bar on Tablet → Space between doorhanger and URL Bar on v11 tablets
/r/7975 - Bug 1159696 - Space between doorhanger and URL bar on v11 tablets. r=ally Pull down this commit: hg pull -r 0fa263f66e855807dfb532af60d6023c4aabf424 https://reviewboard-hg.mozilla.org/gecko/
Attachment #8600206 - Flags: review?(ally)
Comment on attachment 8600206 [details] MozReview Request: bz://1159696/liuche https://reviewboard.mozilla.org/r/7973/#review6789 <rubber stamp> ::: mobile/android/base/resources/values-large-v16/dimens.xml:1 (Diff revision 1) > +<?xml version="1.0" encoding="utf-8"?> there's totally \_9\_ lines in this review, and you promised me 2\! ;)
Attachment #8600206 - Flags: review?(ally) → review+
The doorhanger is correctly displayed under the URL Bar without any space, under the Back button, so: Verified as fixed using: Device:Asus Transformer (Android 4.0.3). Build: Firefox for Android 40.0a1 (2015-05-07)
You need to log in before you can comment on or make changes to this bug.