1159696 - Space between doorhanger and URL Bar on v11 tablets

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Teodora Vermesan (:TeoVermesan)]

Attachment: Screenshot_2015-04-29-14-57-13.jpg

Steps to reproduce:
1. Go to: http://people.mozilla.org/~mleibovic/test/geo.html
2. Scroll down to the "Request location" button and tap it.

Expected results:
- A doorhanger is correctly displayed under the URL Bar, under the Back button

Actual results:
- The doorhanger is not fixed to the URL Bar. There is a space between it and the URL Bar

Note:
- The doorhanger is correctly displayed when disabling "Full-screen browsing"
- regression from Bug 1151505- Doorhanger can appear while browser toolbar is scrolled off screen

Comment 1

[Chenxia Liu [:liuche]]

What device is this? I've been testing on a Nexus 7 and a Nexus 9, and I can't repro this problem. I'll try this on some other devices to see if I can repro.

Comment 2

[Teodora Vermesan (:TeoVermesan)]

I have reproduced the issue using Asus Transformer (Android 4.0.3)

Comment 3

[Chenxia Liu [:liuche]]

This is a regression from bug 1151505. I didn't account for v11 tablets having their system bar on the bottom, while on v16 devices, the system bar is on the top.

Comment 4

[Chenxia Liu [:liuche]]

Attachment: MozReview Request: bz://1159696/liuche

/r/7975 - Bug 1159696 - Space between doorhanger and URL bar on v11 tablets. r=ally

Pull down this commit:

hg pull -r 0fa263f66e855807dfb532af60d6023c4aabf424 https://reviewboard-hg.mozilla.org/gecko/

Comment 5

[Allison Naaktgeboren :ally]

Comment on attachment 8600206 [details]
MozReview Request: bz://1159696/liuche

https://reviewboard.mozilla.org/r/7973/#review6789

<rubber stamp>

::: mobile/android/base/resources/values-large-v16/dimens.xml:1
(Diff revision 1)
> +<?xml version="1.0" encoding="utf-8"?>

there's totally \_9\_ lines in this review, and you promised me 2\! ;)

Comment 6

[Pulsebot]

https://hg.mozilla.org/integration/fx-team/rev/fb7dcd4b7849

Comment 7

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/fb7dcd4b7849

Comment 8

[Teodora Vermesan (:TeoVermesan)]

The doorhanger is correctly displayed under the URL Bar without any space, under the Back button, so:
Verified as fixed using:
Device:Asus Transformer (Android 4.0.3).
Build: Firefox for Android 40.0a1 (2015-05-07)

Comment 10

[Chenxia Liu [:liuche]]

Attachment: MozReview Request: Bug 1159696 - Space between doorhanger and URL bar on v11 tablets. r=ally