Closed
Bug 1159698
Opened 9 years ago
Closed 9 years ago
Opt-out dialog has a button for "disable", but actually the addon is removed
Categories
(Calendar :: Calendar Frontend, defect)
Calendar
Calendar Frontend
Tracking
(Not tracked)
RESOLVED
FIXED
4.0.0.1
People
(Reporter: Fallen, Assigned: MakeMyDay)
References
Details
Attachments
(1 file, 1 obsolete file)
1.81 KB,
patch
|
Fallen
:
review+
Fallen
:
approval-calendar-aurora+
Fallen
:
approval-calendar-beta+
|
Details | Diff | Splinter Review |
STR: In a new profile, wait for the opt-out bar. Click the "Disable" button. Restart Results: The addon is completely removed Expected: The addon is just disabled, or the button should say "Remove". If we don't have strings ourselves for this, we can use the addon manager strings. MakeMyDay, can you take a look?
Flags: needinfo?(makemyday)
Comment 1•9 years ago
|
||
I think just disabling is preferable. http://mxr.mozilla.org/comm-central/source/calendar/lightning/content/messenger-overlay-sidebar.js#216
Reporter | ||
Comment 2•9 years ago
|
||
See bug 1130852 comment 25 to 27, comment 33, comment 36. I think this just got lost in the discussion on the amount of prefs. MakeMyDay prefers uninstall, some others prefer disable. MakeMyday, maybe you can make your case here again :)
Comment 3•9 years ago
|
||
The user can still manually uninstall, right? I'd also support simply disabling.
Assignee | ||
Comment 4•9 years ago
|
||
As discussed on the meeting, we keep the strings and change the behaviour to disabling instead of removing. This patch takes care.
Assignee: nobody → makemyday
Status: NEW → ASSIGNED
Flags: needinfo?(makemyday)
Attachment #8601710 -
Flags: review?(philipp)
Assignee | ||
Comment 5•9 years ago
|
||
One more thing that came to my mind: does it make any difference for the AMO statistic whether we disable or remove?
Reporter | ||
Comment 6•9 years ago
|
||
Comment on attachment 8601710 [details] [diff] [review] DisableInsteadOfRemoveLightning-V1.diff Review of attachment 8601710 [details] [diff] [review]: ----------------------------------------------------------------- r=philipp with this comment considered: ::: calendar/lightning/content/messenger-overlay-sidebar.js @@ +218,3 @@ > }; > let cbUndoRemoveLightning = function (aAddon) { > + aAddon.cancelUninstall(); Shouldn't the undo action be aAddon.userDisabled = false?
Attachment #8601710 -
Flags: review?(philipp)
Attachment #8601710 -
Flags: review+
Attachment #8601710 -
Flags: approval-calendar-beta+
Attachment #8601710 -
Flags: approval-calendar-aurora+
Reporter | ||
Comment 7•9 years ago
|
||
I don't think disabled addons contribute to ADU, they are not active users :)
Assignee | ||
Comment 8•9 years ago
|
||
> Shouldn't the undo action be aAddon.userDisabled = false?
Yes, you're right. Updated patch with comment considered.
Attachment #8601710 -
Attachment is obsolete: true
Assignee | ||
Updated•9 years ago
|
Keywords: checkin-needed
Reporter | ||
Updated•9 years ago
|
Attachment #8602251 -
Flags: review+
Attachment #8602251 -
Flags: approval-calendar-beta+
Attachment #8602251 -
Flags: approval-calendar-aurora+
Reporter | ||
Comment 9•9 years ago
|
||
Pushed to comm-central changeset 099ffdaa0416
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → 4.2
Reporter | ||
Comment 10•9 years ago
|
||
Backported to releases/comm-aurora changeset 89722d50d1f1
Target Milestone: 4.2 → 4.1
Reporter | ||
Comment 11•9 years ago
|
||
Backported to releases/comm-beta changeset d378aa365a2d
Target Milestone: 4.1 → 4.0
You need to log in
before you can comment on or make changes to this bug.
Description
•