Calendar tab toolbar buttons are missing tooltips

RESOLVED FIXED in 4.3

Status

Calendar
General
RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: aleth, Assigned: Stefan Sitter)

Tracking

Trunk

Details

Attachments

(1 attachment, 1 obsolete attachment)

(Reporter)

Description

2 years ago
For a new user, it would be helpful if the calendar tab buttons (Synchronize, Event, Task,...) had explanatory tooltips which explain what the buttons are for (e.g. synchronize with what? does it open an Event view or add a new event or...?)
(Reporter)

Updated

2 years ago
Flags: tb-integration?
(Assignee)

Comment 1

2 years ago
This is pretty easy, taking :)
Assignee: nobody → ssitter
Status: NEW → ASSIGNED
(Assignee)

Comment 2

2 years ago
Created attachment 8602914 [details] [diff] [review]
add tooltips to Calendar tab and Task tab toolbar buttons
Attachment #8602914 - Flags: review?(matthew.mecca)
Comment on attachment 8602914 [details] [diff] [review]
add tooltips to Calendar tab and Task tab toolbar buttons

Review of attachment 8602914 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good, r=mmecca

::: calendar/locales/en-US/chrome/lightning/lightning-toolbar.dtd
@@ +7,5 @@
>  <!ENTITY lightning.toolbar.task.name "Task Toolbar">
>  <!ENTITY lightning.toolbar.task.name.accesskey "T">
>  
>  <!ENTITY lightning.toolbar.sync.label "Synchronize">
> +<!ENTITY lightning.toolbar.sync.tooltip "Reload calendar and synchronize changes">

We should probably use the plural form "calendars" here since all calendars are refreshed.

@@ +12,2 @@
>  <!ENTITY lightning.toolbar.delete.label "Delete">
> +<!ENTITY lightning.toolbar.delete.tooltip "Delete selected event or task">

Here also, since there could be multiple events or tasks deleted.

@@ +18,2 @@
>  <!ENTITY lightning.toolbar.print.label "Print">
> +<!ENTITY lightning.toolbar.print.tooltip "Print selected event or task">

Should this be more generic, since the print dialog isn't limited to the current selection? Maybe just "Print events and tasks"
Attachment #8602914 - Flags: review?(matthew.mecca) → review+
(Assignee)

Comment 4

2 years ago
(In reply to Matthew Mecca [:mmecca] from comment #3)
> We should probably use the plural form "calendars" here since all calendars
> are refreshed.
> ...
> Here also, since there could be multiple events or tasks deleted.

I tried to align with tooltips used in Thunderbird and they use singular although the command applies to one or more elements (e.g. Delete selected message or folder)

> Should this be more generic, since the print dialog isn't limited to the
> current selection? Maybe just "Print events and tasks"

Sure, I can update the patch.
(Assignee)

Comment 5

2 years ago
Created attachment 8613023 [details] [diff] [review]
add tooltips to Calendar tab and Task tab toolbar buttons, v2
Attachment #8602914 - Attachment is obsolete: true
Attachment #8613023 - Flags: review?(matthew.mecca)
Comment on attachment 8613023 [details] [diff] [review]
add tooltips to Calendar tab and Task tab toolbar buttons, v2

r=mmecca
Attachment #8613023 - Flags: review?(matthew.mecca) → review+
(Assignee)

Updated

2 years ago
Keywords: checkin-needed
(Assignee)

Comment 7

2 years ago
Pushed to https://hg.mozilla.org/comm-central/rev/331e683af864
Status: ASSIGNED → RESOLVED
Last Resolved: 2 years ago
Flags: tb-integration?
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → 4.3
You need to log in before you can comment on or make changes to this bug.