1159718 - Remove notification when 'quick open' is activated in Tab Queue

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: Overlays, defect)

Description

[Martyn Haigh (:mhaigh)]

As noted in https://bugzilla.mozilla.org/show_bug.cgi?id=1154425#c18 - with Tab Queue enabled, when you tap a link and wait for the toast to hide, then quickly (< 3 seconds) tap the same link again, the link is opened but the notification is not removed.  

We need to remove the notification if it's displayed when quick open is activated.

Comment 1

[Martyn Haigh (:mhaigh)]

Attachment: Remove notification when 'quick open' is activated in Tab Queue

Comment 2

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

Comment on attachment 8599330 [details] [diff] [review]
Remove notification when 'quick open' is activated in Tab Queue

Review of attachment 8599330 [details] [diff] [review]:
-----------------------------------------------------------------

::: mobile/android/base/tabqueue/TabQueueHelper.java
@@ +231,5 @@
>          final SharedPreferences prefs = GeckoSharedPrefs.forApp(context);
>          prefs.edit().remove(PREF_TAB_QUEUE_COUNT).apply();
>      }
>  
> +    static void removeNotification(Context context) {

For my edification, any reason you preferred package-private to protected here? Unless I'm making a public API, I don't see much use in limiting subclass access.

Comment 3

[Martyn Haigh (:mhaigh)]

https://hg.mozilla.org/integration/fx-team/rev/3b908ec52d4e

Comment 4

[Martyn Haigh (:mhaigh)]

> For my edification, any reason you preferred package-private to protected
> here? Unless I'm making a public API, I don't see much use in limiting
> subclass access.

Old habit - no good reason in this case :)

Comment 5

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/3b908ec52d4e

Comment 6

[Teodora Vermesan (:TeoVermesan)]

Tapping a link external to Firefox will generate in the android notification bar "Nightly - 1 tab waiting" and tapping once again on the link will open it in Firefox in a new tab. The notification is removed from the notification bar.

Verified as fixed using:
Device: Samsung S5 (Android 4.4.2)
Build: Firefox for Android 40.0a1 (2015-05-06)