Closed
Bug 1159786
Opened 10 years ago
Closed 7 years ago
Write tests to cover code in th_publisher.post_treeherder_collection function
Categories
(Tree Management :: Treeherder, defect, P3)
Tree Management
Treeherder
Tracking
(Not tracked)
RESOLVED
WONTFIX
People
(Reporter: camd, Unassigned)
References
Details
We had an error where this line:
if not response or response.status != 200:
was accidentally set to:
if not response or response.status == 200:
Which broke things, but didn't break any tests. We need at least 1 test that this will break so we can catch it.
However, due to the way ``thclient`` is written using ``httplib`` instead of ``requests``, this is not possible. Our test framework doesn't support the same response values. So waiting on that bug to be fixed.
Reporter | ||
Updated•10 years ago
|
Assignee: nobody → cdawson
Updated•10 years ago
|
Priority: -- → P3
Reporter | ||
Updated•10 years ago
|
Assignee: cdawson → nobody
Comment 1•7 years ago
|
||
post_treeherder_collection no longer exists.
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → WONTFIX
You need to log in
before you can comment on or make changes to this bug.
Description
•