Kill full gc timer when gc starts

RESOLVED WONTFIX

Status

()

defect
RESOLVED WONTFIX
4 years ago
5 months ago

People

(Reporter: smaug, Assigned: smaug)

Tracking

36 Branch
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

Posted patch v1Splinter Review
We have similar Kill*Timer calls in nsJSContext::GarbageCollectNow.
Attachment #8599403 - Flags: review?(continuation)
Comment on attachment 8599403 [details] [diff] [review]
v1

Review of attachment 8599403 [details] [diff] [review]:
-----------------------------------------------------------------

Oh, PreciseGCRunnable::Run() starts a GC by directly calling JSAPIs.  Fun.
Attachment #8599403 - Flags: review?(continuation) → review+
I guess we want this on FxOS v2.2 as well?
well, if this helps with the testing. In practice this shouldn't affect actual behavior too much.
tryserver is a bit orange. Most of the failures are known, but not all :/
I'll land this to m-i.  For some reason also that previous try push had quite a few known failures.
Hopefully this isn't making try more flaky (though that would mean we have some bugs in the tests).
This apparently made reftest-unaccelerated tests on at least Windows 7 start failing, so I backed it out in https://hg.mozilla.org/integration/mozilla-inbound/rev/d1c2ecd59fc0

https://treeherder.mozilla.org/logviewer.html#?job_id=9558026&repo=mozilla-inbound
Flags: needinfo?(bugs)
Pretty sure it's also responsible for android reftest-8 failures like https://treeherder.mozilla.org/logviewer.html#?job_id=9556030&repo=mozilla-inbound
Not just Android debug reftest-8, final tally looks more like 1, 2, 3, 4, 7, 8 which probably means "any of them if you happen to hit them right." Impossible to say whether you had any similar effect on Android debug mochitests, since you landed on top of a patch which made them fail to start and infinitely retry, so it'd be a good idea to include them in the try push where you check whether you've stopped randomly killing Android debug reftests.
Sorry about that.

Looks like fixing this isn't really worth.

For https://bugzilla.mozilla.org/show_bug.cgi?id=1099195#c2027 we should just make
PreciseGCRunnable to use the normal GC triggering methods.
Status: NEW → RESOLVED
Closed: 4 years ago
Flags: needinfo?(bugs)
Resolution: --- → WONTFIX
Depends on: 1161491
Component: DOM → DOM: Core & HTML
You need to log in before you can comment on or make changes to this bug.