Closed Bug 1159830 Opened 5 years ago Closed 5 years ago

Autophone - webappstartup should not use console.log to output WEBAPP STARTUP COMPLETE

Categories

(Testing :: Autophone, defect)

defect
Not set

Tracking

(firefox39 fixed, firefox40 fixed, firefox41 fixed)

RESOLVED FIXED
mozilla41
Tracking Status
firefox39 --- fixed
firefox40 --- fixed
firefox41 --- fixed

People

(Reporter: bc, Assigned: rbarker)

References

()

Details

(Keywords: sec-other, Whiteboard: [adv-main39-])

Attachments

(1 file, 1 obsolete file)

Firefox for Android Beta, Aurora? and Release no longer allow console.log to output to logcat due to bug 1149094. I've disabled webappstartup on release, beta, and aurora as a result.

sec-other to hide bug 1149094.
snorp: mfinkle mentioned maybe using Java to output the message to logcat. What do you think?
Flags: needinfo?(snorp)
I guess the plan here is to add a pref that will re-enable the logcat output. Randall can you add this please? Bob, you'll then need a prefs update that flips the right thing.
Assignee: nobody → rbarker
Flags: needinfo?(snorp)
Bob this should still be working in Aurora, so you can re-enable there.
Ok, will do on next deployment.
(In reply to James Willcox (:snorp) (jwillcox@mozilla.com) from comment #2)
> I guess the plan here is to add a pref that will re-enable the logcat
> output. Randall can you add this please? Bob, you'll then need a prefs
> update that flips the right thing.

Is there any way I can see bug 1149094 so I don't have to hunt through the code to figure out what was changed?
Flags: needinfo?(snorp)
rbarker: I ccd you.
Flags: needinfo?(snorp)
Comment on attachment 8600053 [details] [diff] [review]
0001-Bug-1159830-Autophone-webappstartup-should-not-use-console.log-to-output-WEBAPP-STARTUP-COMPLETE-15043013-8b3f221.patch

Who else should review this?

https://treeherder.mozilla.org/#/jobs?repo=try&revision=acbfa67ee778
Attachment #8600053 - Flags: review?(snorp)
Attachment #8600053 - Flags: review?(snorp) → review+
Carry forward r+ from :snorp. Rebase to tip of tree.
Attachment #8600053 - Attachment is obsolete: true
Attachment #8611483 - Flags: review?(nfroyd)
Comment on attachment 8611483 [details] [diff] [review]
0001-Bug-1159830-Autophone-webappstartup-should-not-use-console.log-to-output-WEBAPP-STARTUP-COMPLETE-15052714-288abf1.patch

Review of attachment 8611483 [details] [diff] [review]:
-----------------------------------------------------------------

Just to make sure I'm clear here, being unfamiliar with webappstartup: we would use console.log to write some message(s), which were output through logcat.  And these messages are somehow important (?).  But then bug 1149094 came along, and we were unable to output those messages.  So this patch restores the ability to output those messages for non-release builds?
Attachment #8611483 - Flags: review?(nfroyd) → review+
(In reply to Nathan Froyd [:froydnj] [:nfroyd] from comment #10)
> Comment on attachment 8611483 [details] [diff] [review]
> 0001-Bug-1159830-Autophone-webappstartup-should-not-use-console.log-to-
> output-WEBAPP-STARTUP-COMPLETE-15052714-288abf1.patch
> 
> Review of attachment 8611483 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> Just to make sure I'm clear here, being unfamiliar with webappstartup: we
> would use console.log to write some message(s), which were output through
> logcat.  And these messages are somehow important (?).  But then bug 1149094
> came along, and we were unable to output those messages.  So this patch
> restores the ability to output those messages for non-release builds?

On android, console.log used to go to logcat. It was originally just disabled on RELEASE builds. However this broke some tests. This patch allows a preference to be set to re-enable sending console.log to logcat so that tests for RELEASE builds maybe re-enabled.
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/6c009ae07819
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla41
I need to add consoleservice.logcat true to the webappstartup at least, then enable webappstartup on beta and release.
Blocks: 1166749
Flags: needinfo?(bob)
No longer blocks: 1166749
Blocks: 1172329
I landed the pref change in bug 1172334 but I can't start running webappstartup on beta, release unless this is uplifted. rbarker, snorp: can we uplift this to aurora, beta and release?
Flags: needinfo?(snorp)
Flags: needinfo?(rbarker)
Flags: needinfo?(bob)
It'll be a hard sell to get this on release, but the others seem fine to me.
Flags: needinfo?(snorp)
Should I request uplift for beta and aurora? I assume it would then go into next release since the whole point of this was to fix testing breakage in release builds.
Flags: needinfo?(rbarker)
beta and aurora will be fine.
Comment on attachment 8611483 [details] [diff] [review]
0001-Bug-1159830-Autophone-webappstartup-should-not-use-console.log-to-output-WEBAPP-STARTUP-COMPLETE-15052714-288abf1.patch

Approval Request Comment
[Feature/regressing bug #]: Bug 1159830
[User impact if declined]: Will not be able to re-enable tests.
[Describe test coverage new/current, TreeHerder]: some autophone test are disabled until this fix lands in Aurora and/or Beta.
[Risks and why]: None known.
[String/UUID change made/needed]: None.
Attachment #8611483 - Flags: approval-mozilla-beta?
Attachment #8611483 - Flags: approval-mozilla-aurora?
Comment on attachment 8611483 [details] [diff] [review]
0001-Bug-1159830-Autophone-webappstartup-should-not-use-console.log-to-output-WEBAPP-STARTUP-COMPLETE-15052714-288abf1.patch

Approved for uplift to aurora and beta. This lets us enable another batch of tests.
Attachment #8611483 - Flags: approval-mozilla-beta?
Attachment #8611483 - Flags: approval-mozilla-beta+
Attachment #8611483 - Flags: approval-mozilla-aurora?
Attachment #8611483 - Flags: approval-mozilla-aurora+
Whiteboard: [adv-main39-]
Group: core-security → core-security-release
Group: core-security-release
You need to log in before you can comment on or make changes to this bug.