1159876 - Dismiss Doorhanger when user clicks on Edit site settings

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: General, defect)

Comment 1

[Chenxia Liu [:liuche]]

Attachment: MozReview Request: bz://1159876/liuche

/r/8197 - Bug 1159876 - Dismiss Doorhanger when user clicks on Edit site settings. r=ally

Pull down this commit:

hg pull -r 908daffad217e4a5be7339039e4dc8a155b3a239 https://reviewboard-hg.mozilla.org/gecko/

Comment 2

[Allison Naaktgeboren :ally]

https://reviewboard.mozilla.org/r/8197/#review6953

Ship It!

::: mobile/android/base/widget/LoginDoorHanger.java:177
(Diff revision 1)
> +                            dialog.dismiss();

I don't know why you even need me for this. :)

Comment 3

[Pulsebot]

https://hg.mozilla.org/integration/fx-team/rev/09a0d7b4527a

Comment 4

[Allison Naaktgeboren :ally]

https://reviewboard.mozilla.org/r/8197/#review7007

Ship It!

Comment 5

[Allison Naaktgeboren :ally]

Ive poked mozreview twice, but this bug is still listed as r? ...

Comment 6

[Chenxia Liu [:liuche]]

So this is the same problem you encountered during one of the previous reviews, if you remember. You have to click to the top-level review, and then click review/ship it, and Reviewboard will automatically flip the review flag in the bug.

Alternatively, you can also just r+ this in the bug.

There's a bug on file for this, but I can't remember what it is - you can ping mconley if you want to cc yourself to the bug.

(None of this actually matters, because I landed this bug this morning, after you r+ ed from reviewboard.)

Comment 7

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/09a0d7b4527a

Comment 8

[Teodora Vermesan (:TeoVermesan)]

Is this issue fixed?
Tested with latest Nightly (2015-05-08) using Samsung galaxy Nexus (Android 4.2.1), tapping "Edit Site Settings" won't dismiss the doorhanger

Comment 9

[Chenxia Liu [:liuche]]

Hm, I backed this out, let me see what's wrong.
https://hg.mozilla.org/integration/fx-team/rev/c7b9e3ebd763

Comment 10

[Pulsebot]

https://hg.mozilla.org/integration/fx-team/rev/8edc3877e0e0

Comment 11

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/8edc3877e0e0

Comment 12

[:Margaret Leibovic]

I'm confused... did you just re-land a different version of this patch that fixed the issue?

Pulsebot is great, but doesn't provide much context :)

Comment 13

[Chenxia Liu [:liuche]]

Yeah, I backed out the original patch, and then relanded a new version.

Comment 14

[Teodora Vermesan (:TeoVermesan)]

Tapping "Edit Site Settings" dismisses the doorhanger,
Verified as fixed using:
Device: Samsung S5 (Android 4.4.4)
Build: Firefox for Android 40.0a2 (2015-05-27) and Firefox for Android 41.0a1 (2015-05-26)

Comment 16

[Chenxia Liu [:liuche]]

Attachment: MozReview Request: Bug 1159876 - Dismiss Doorhanger when user clicks on Edit site settings. r=ally