Closed Bug 1159876 Opened 5 years ago Closed 5 years ago

Dismiss Doorhanger when user clicks on Edit site settings

Categories

(Firefox for Android :: General, defect)

ARM
Android
defect
Not set
normal

Tracking

()

VERIFIED FIXED
Firefox 40
Tracking Status
firefox40 --- verified
firefox41 --- verified

People

(Reporter: liuche, Assigned: liuche)

References

Details

Attachments

(1 file, 1 obsolete file)

No description provided.
Attached file MozReview Request: bz://1159876/liuche (obsolete) —
/r/8197 - Bug 1159876 - Dismiss Doorhanger when user clicks on Edit site settings. r=ally

Pull down this commit:

hg pull -r 908daffad217e4a5be7339039e4dc8a155b3a239 https://reviewboard-hg.mozilla.org/gecko/
Attachment #8601836 - Flags: review?(ally)
Assignee: nobody → liuche
https://reviewboard.mozilla.org/r/8197/#review6953

Ship It!

::: mobile/android/base/widget/LoginDoorHanger.java:177
(Diff revision 1)
> +                            dialog.dismiss();

I don't know why you even need me for this. :)
Ive poked mozreview twice, but this bug is still listed as r? ...
Flags: needinfo?(liuche)
So this is the same problem you encountered during one of the previous reviews, if you remember. You have to click to the top-level review, and then click review/ship it, and Reviewboard will automatically flip the review flag in the bug.

Alternatively, you can also just r+ this in the bug.

There's a bug on file for this, but I can't remember what it is - you can ping mconley if you want to cc yourself to the bug.

(None of this actually matters, because I landed this bug this morning, after you r+ ed from reviewboard.)
Flags: needinfo?(liuche)
https://hg.mozilla.org/mozilla-central/rev/09a0d7b4527a
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 40
Attachment #8601836 - Flags: review?(ally) → review+
Is this issue fixed?
Tested with latest Nightly (2015-05-08) using Samsung galaxy Nexus (Android 4.2.1), tapping "Edit Site Settings" won't dismiss the doorhanger
Hm, I backed this out, let me see what's wrong.
https://hg.mozilla.org/integration/fx-team/rev/c7b9e3ebd763
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
https://hg.mozilla.org/mozilla-central/rev/8edc3877e0e0
Status: REOPENED → RESOLVED
Closed: 5 years ago5 years ago
Resolution: --- → FIXED
I'm confused... did you just re-land a different version of this patch that fixed the issue?

Pulsebot is great, but doesn't provide much context :)
Flags: needinfo?(liuche)
Yeah, I backed out the original patch, and then relanded a new version.
Flags: needinfo?(liuche)
Tapping "Edit Site Settings" dismisses the doorhanger,
Verified as fixed using:
Device: Samsung S5 (Android 4.4.4)
Build: Firefox for Android 40.0a2 (2015-05-27) and Firefox for Android 41.0a1 (2015-05-26)
Status: RESOLVED → VERIFIED
Attachment #8601836 - Attachment is obsolete: true
Attachment #8620192 - Flags: review+
You need to log in before you can comment on or make changes to this bug.