Closed
Bug 1159876
Opened 9 years ago
Closed 9 years ago
Dismiss Doorhanger when user clicks on Edit site settings
Categories
(Firefox for Android Graveyard :: General, defect)
Tracking
(firefox40 verified, firefox41 verified)
VERIFIED
FIXED
Firefox 40
People
(Reporter: liuche, Assigned: liuche)
References
Details
Attachments
(1 file, 1 obsolete file)
No description provided.
Assignee | ||
Comment 1•9 years ago
|
||
/r/8197 - Bug 1159876 - Dismiss Doorhanger when user clicks on Edit site settings. r=ally Pull down this commit: hg pull -r 908daffad217e4a5be7339039e4dc8a155b3a239 https://reviewboard-hg.mozilla.org/gecko/
Attachment #8601836 -
Flags: review?(ally)
Assignee | ||
Updated•9 years ago
|
Assignee: nobody → liuche
Comment 2•9 years ago
|
||
https://reviewboard.mozilla.org/r/8197/#review6953 Ship It! ::: mobile/android/base/widget/LoginDoorHanger.java:177 (Diff revision 1) > + dialog.dismiss(); I don't know why you even need me for this. :)
Comment 4•9 years ago
|
||
https://reviewboard.mozilla.org/r/8197/#review7007 Ship It!
Comment 5•9 years ago
|
||
Ive poked mozreview twice, but this bug is still listed as r? ...
Flags: needinfo?(liuche)
Assignee | ||
Comment 6•9 years ago
|
||
So this is the same problem you encountered during one of the previous reviews, if you remember. You have to click to the top-level review, and then click review/ship it, and Reviewboard will automatically flip the review flag in the bug. Alternatively, you can also just r+ this in the bug. There's a bug on file for this, but I can't remember what it is - you can ping mconley if you want to cc yourself to the bug. (None of this actually matters, because I landed this bug this morning, after you r+ ed from reviewboard.)
Flags: needinfo?(liuche)
Comment 7•9 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/09a0d7b4527a
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 40
Updated•9 years ago
|
Attachment #8601836 -
Flags: review?(ally) → review+
Comment 8•9 years ago
|
||
Is this issue fixed? Tested with latest Nightly (2015-05-08) using Samsung galaxy Nexus (Android 4.2.1), tapping "Edit Site Settings" won't dismiss the doorhanger
Assignee | ||
Comment 9•9 years ago
|
||
Hm, I backed this out, let me see what's wrong. https://hg.mozilla.org/integration/fx-team/rev/c7b9e3ebd763
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Comment 11•9 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/8edc3877e0e0
Status: REOPENED → RESOLVED
Closed: 9 years ago → 9 years ago
Resolution: --- → FIXED
Comment 12•9 years ago
|
||
I'm confused... did you just re-land a different version of this patch that fixed the issue? Pulsebot is great, but doesn't provide much context :)
Flags: needinfo?(liuche)
Assignee | ||
Comment 13•9 years ago
|
||
Yeah, I backed out the original patch, and then relanded a new version.
Flags: needinfo?(liuche)
Comment 14•9 years ago
|
||
Tapping "Edit Site Settings" dismisses the doorhanger, Verified as fixed using: Device: Samsung S5 (Android 4.4.4) Build: Firefox for Android 40.0a2 (2015-05-27) and Firefox for Android 41.0a1 (2015-05-26)
Assignee | ||
Comment 15•9 years ago
|
||
Attachment #8601836 -
Attachment is obsolete: true
Attachment #8620192 -
Flags: review+
Assignee | ||
Comment 16•9 years ago
|
||
Updated•3 years ago
|
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•