Closed Bug 1159876 Opened 5 years ago Closed 5 years ago
Dismiss Doorhanger when user clicks on Edit site settings
39 bytes, text/x-review-board-request
No description provided.
/r/8197 - Bug 1159876 - Dismiss Doorhanger when user clicks on Edit site settings. r=ally Pull down this commit: hg pull -r 908daffad217e4a5be7339039e4dc8a155b3a239 https://reviewboard-hg.mozilla.org/gecko/
Attachment #8601836 - Flags: review?(ally)
https://reviewboard.mozilla.org/r/8197/#review6953 Ship It! ::: mobile/android/base/widget/LoginDoorHanger.java:177 (Diff revision 1) > + dialog.dismiss(); I don't know why you even need me for this. :)
Ive poked mozreview twice, but this bug is still listed as r? ...
So this is the same problem you encountered during one of the previous reviews, if you remember. You have to click to the top-level review, and then click review/ship it, and Reviewboard will automatically flip the review flag in the bug. Alternatively, you can also just r+ this in the bug. There's a bug on file for this, but I can't remember what it is - you can ping mconley if you want to cc yourself to the bug. (None of this actually matters, because I landed this bug this morning, after you r+ ed from reviewboard.)
Attachment #8601836 - Flags: review?(ally) → review+
Is this issue fixed? Tested with latest Nightly (2015-05-08) using Samsung galaxy Nexus (Android 4.2.1), tapping "Edit Site Settings" won't dismiss the doorhanger
Hm, I backed this out, let me see what's wrong. https://hg.mozilla.org/integration/fx-team/rev/c7b9e3ebd763
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Status: REOPENED → RESOLVED
Closed: 5 years ago → 5 years ago
Resolution: --- → FIXED
I'm confused... did you just re-land a different version of this patch that fixed the issue? Pulsebot is great, but doesn't provide much context :)
Yeah, I backed out the original patch, and then relanded a new version.
Tapping "Edit Site Settings" dismisses the doorhanger, Verified as fixed using: Device: Samsung S5 (Android 4.4.4) Build: Firefox for Android 40.0a2 (2015-05-27) and Firefox for Android 41.0a1 (2015-05-26)
You need to log in before you can comment on or make changes to this bug.