Closed Bug 1159904 Opened 5 years ago Closed 5 years ago

JavaScript Warning: "SyntaxError: unreachable code after return statement" {file: "chrome://browser/content/Reader.js" line: 291 column: 7 }

Categories

(Firefox for Android :: Reader View, defect)

35 Branch
defect
Not set

Tracking

()

RESOLVED FIXED
Firefox 41
Tracking Status
firefox41 --- fixed

People

(Reporter: Margaret, Assigned: clayton2, Mentored)

Details

(Whiteboard: [good first bug][lang=js])

Attachments

(1 file, 1 obsolete file)

Looks like this warning is in _getArticle.

To fix this bug, you should first try to reproduce this by building and running Firefox for Android, and looking in the log. Then you should look into Reader.js to try to see if you can make the warning go away.
Hi Margaret,

I would like to take this and work on it. I am new Mozilla volunteer and this is my first bug.


Regards,
Nithya
Hi, Nithya! First of all, you'll want to set up a Firefox for Android build environment. You can find instructions for that here: https://wiki.mozilla.org/Mobile/Fennec/Android#Building_Fennec

After that, you should try to reproduce the issue as I mentioned in comment 0. You can use adb logcat to look at the logs:
https://wiki.mozilla.org/Mobile/Fennec/Android#Using_logcat

Please join us in #mobile on irc.mozilla.org to ask questions if you run into any issues; you can find instructions here, https://wiki.mozilla.org/IRC#Getting_Started. Also, feel free to say Hi to introduce yourself!
Attached patch Fixed syntax error in Reader.js (obsolete) — Splinter Review
Attachment #8603857 - Attachment is obsolete: true
Attachment #8603859 - Flags: review?(margaret.leibovic)
Comment on attachment 8603859 [details] [diff] [review]
Fixed syntax error in Reader.js

Review of attachment 8603859 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good, thanks for the patch!
Attachment #8603859 - Flags: review?(margaret.leibovic) → review+
This patch will be automatically checked in for you soon. Let me know if you need help finding more bugs to work on! :)
Assignee: nobody → clayton2
Keywords: checkin-needed
https://hg.mozilla.org/integration/fx-team/rev/e2c1e8294bfd
Keywords: checkin-needed
Whiteboard: [good first bug][lang=js] → [good first bug][lang=js][fixed-in-fx-team]
https://hg.mozilla.org/mozilla-central/rev/e2c1e8294bfd
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Whiteboard: [good first bug][lang=js][fixed-in-fx-team] → [good first bug][lang=js]
Target Milestone: --- → Firefox 41
You need to log in before you can comment on or make changes to this bug.