1159904 - JavaScript Warning: "SyntaxError: unreachable code after return statement" {file: "chrome://browser/content/Reader.js" line: 291 column: 7 }

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: Reader View, defect)

Description

[:Margaret Leibovic]

Looks like this warning is in _getArticle.

To fix this bug, you should first try to reproduce this by building and running Firefox for Android, and looking in the log. Then you should look into Reader.js to try to see if you can make the warning go away.

Comment 1

[Nithyakumaran Gnanasekar]

Hi Margaret,

I would like to take this and work on it. I am new Mozilla volunteer and this is my first bug.


Regards,
Nithya

Comment 2

[:Margaret Leibovic]

Hi, Nithya! First of all, you'll want to set up a Firefox for Android build environment. You can find instructions for that here: https://wiki.mozilla.org/Mobile/Fennec/Android#Building_Fennec

After that, you should try to reproduce the issue as I mentioned in comment 0. You can use adb logcat to look at the logs:
https://wiki.mozilla.org/Mobile/Fennec/Android#Using_logcat

Please join us in #mobile on irc.mozilla.org to ask questions if you run into any issues; you can find instructions here, https://wiki.mozilla.org/IRC#Getting_Started. Also, feel free to say Hi to introduce yourself!

Comment 3

[Clayton Bodendein]

Attachment: Fixed syntax error in Reader.js

Comment 4

[Clayton Bodendein]

Attachment: Fixed syntax error in Reader.js

Comment 5

[:Margaret Leibovic]

Comment on attachment 8603859 [details] [diff] [review]
Fixed syntax error in Reader.js

Review of attachment 8603859 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good, thanks for the patch!

Comment 6

[:Margaret Leibovic]

This patch will be automatically checked in for you soon. Let me know if you need help finding more bugs to work on! :)

Comment 7

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/fx-team/rev/e2c1e8294bfd

Comment 8

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/e2c1e8294bfd