Closed
Bug 1159959
Opened 10 years ago
Closed 9 years ago
UX: would be nice to have the submit button stickied.
Categories
(Firefox OS Graveyard :: Gaia::Bugzilla Lite, defect)
Tracking
(feature-b2g:2.5+)
People
(Reporter: nhirata, Assigned: daleharvey)
References
Details
(Keywords: feature, foxfood)
Attachments
(2 files)
1. install bugzilla lite staging client : via https://bzlite-staging.herokuapp.com/install.html
2. log into bugzilla lite
3. set device to logshake
4. shake the devie
5. select the notification for the log and share to bugzilla lite
6. type in title / body
7. submit
Actual: you have to scroll down a lot to submit the bug
Expected: you shouldn't have to scroll so much...
Reporter | ||
Updated•10 years ago
|
Flags: needinfo?(swilkes)
Updated•10 years ago
|
Flags: needinfo?(swilkes) → needinfo?(jsavory)
Comment 1•10 years ago
|
||
I do agree that with the amount of attachments the logs come with, there is quite a bit of scrolling. We can solve this by having the 'Submit' button be sticky to the bottom of the screen rather than placed at the bottom of the page.
ni - Amy, just fyi and in case you need to update the visual spec.
Flags: needinfo?(jsavory) → needinfo?(amlee)
Assignee | ||
Comment 2•10 years ago
|
||
Again borrowing from the email and sms applications UI the reply field and submit button could be fixed along the bottom of the screen here
Assignee | ||
Comment 3•10 years ago
|
||
Actually email doesnt do that, it has the submit along the top and the whole screen as the reply, sms has them together fixed at the bottom of the screen
This will likely be a v2 improvement, so best to reference the current implementation (http://www.bzlite.com/bug/1156225)
Comment 4•10 years ago
|
||
Hi,
I've updated the spec with the submit button to be stick to the bottom of the screen.
https://bug1134701.bugzilla.mozilla.org/attachment.cgi?id=8601677
Flags: needinfo?(amlee)
Reporter | ||
Comment 5•9 years ago
|
||
matching the title to match the UX design.
Summary: UX: would be nice to have the submit button above the attachments → UX: would be nice to have the submit button stickied.
Assignee | ||
Comment 6•9 years ago
|
||
We no longer have the logout in the header here, how about putting submit on the top right which matches the conventions we use elsewhere?
Flags: needinfo?(amlee)
Comment 9•9 years ago
|
||
This sounds good to me. As you mentioned, Dale, this is a convention we use in the device and will clear up some of the vertical space.
Flags: needinfo?(jsavory)
Assignee | ||
Updated•9 years ago
|
Blocks: 2.5_BugzillaLite
Reporter | ||
Updated•9 years ago
|
Updated•9 years ago
|
feature-b2g: --- → 2.5+
Assignee | ||
Updated•9 years ago
|
Assignee: nobody → dale
Assignee | ||
Comment 10•9 years ago
|
||
Yo, I mentioned I may ask you reviews for this from time to time.
This just moves the submit button from the bottom of the screen to the header, as a side effect it also fixes https://bugzilla.mozilla.org/show_bug.cgi?id=1178341 as forms wont get automatically submitted on pressing enter now
Attachment #8644296 -
Flags: review?(dietrich)
Comment 12•9 years ago
|
||
Comment on attachment 8644296 [details] [review]
https://github.com/mozilla-b2g/bzlite/pull/30
minor question in the patch, but r=me.
Attachment #8644296 -
Flags: review?(dietrich) → review+
Assignee | ||
Comment 13•9 years ago
|
||
And landed, thanks
https://github.com/mozilla-b2g/bzlite/commit/22ccc7f54fd61c6ae0be497f6c88b6817f17b496
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Updated•9 years ago
|
Target Milestone: --- → FxOS-S4 (07Aug)
Comment 14•9 years ago
|
||
This looks good to me
Comment 15•9 years ago
|
||
This is verified fixed based on decision at Comment 6. See attached screenshot for verified behavior (submit button on top).
Device: Aries 2.5
BuildID: 20150831032308
Gaia: 31e595f86f6bf159b3a9a46816a6ac00a55ca9f9
Gecko: f2518b8a7b97b5bb477e94bc9131584007aac887
Gonk: 2916e2368074b5383c80bf5a0fba3fc83ba310bd
Version: 43.0a1 (2.5)
Firmware Version: D5803_23.1.A.1.28_NCB.ftf
User Agent: Mozilla/5.0 (Mobile; rv:43.0) Gecko/43.0 Firefox/43.0
Updated•9 years ago
|
Status: RESOLVED → VERIFIED
QA Whiteboard: [QAnalyst-Triage?]
Flags: needinfo?(jmercado)
Keywords: verifyme
Updated•9 years ago
|
QA Whiteboard: [QAnalyst-Triage?] → [QAnalyst-Triage+]
Flags: needinfo?(jmercado)
You need to log in
before you can comment on or make changes to this bug.
Description
•