1159960 - [fxos-automation] Add support for taskcluster npm-cache in gecko

Status: RESOLVED FIXED

(Taskcluster :: General, defect)

Description

[Aus Lacroix [:aus]]

We are using the new npm-cache mechanism for everything gaia but we really should turn this on for gecko ASAP.

Comment 1

[Aus Lacroix [:aus]]

Current big hopes and dreams is to have this ready'ish by Friday to test over the weekend and deploy to all on Monday or Tuesday. :)

Comment 2

[Aus Lacroix [:aus]]

Things that need to happen to make this work:

* Update mozharness (https://hg.mozilla.org/build/mozharness/file/cf3b33c04c78/mozharness/mozilla/gaia.py) to use NODE_MODULE_SRC=npm-cache.
* Update gecko mozharness revision http://mxr.mozilla.org/mozilla-central/source/testing/mozharness/mozharness.json
* Add taskcluster-npm-cache to the global node modules installed in the docker worker image (http://mxr.mozilla.org/mozilla-central/source/testing/docker/tester/Dockerfile)
* Bump VERSION (http://mxr.mozilla.org/mozilla-central/source/testing/docker/tester/VERSION)

The most annoying part is actually making the new version of mozharness testable since it's pulled from from a specific place with a specific revision. I'm expecting I will need to setup a branch for this ASAP.

Comment 3

[Aus Lacroix [:aus]]

Attachment: Patch - v1 - Update mozharness to use taskcluster-npm-cache

Comment 4

[Aus Lacroix [:aus]]

Attachment: Patch - v1 - Update tester docker image

Comment 5

[Aus Lacroix [:aus]]

Attachment: Patch - v1 - Update mozharness to use taskcluster-npm-cache

Comment 6

[James Lal [:lightsofapollo]]

Comment on attachment 8604953 [details] [diff] [review]
Patch - v1 - Update tester docker image

lgtm...

Lets try to land the version bump ASAP

Comment 7

[Jonathan Griffin (:jgriffin)]

Comment on attachment 8604956 [details] [diff] [review]
Patch - v1 - Update mozharness to use taskcluster-npm-cache

Review of attachment 8604956 [details] [diff] [review]:
-----------------------------------------------------------------

This looks good from a mozharness perspective.  I don't know how the npm cache works, so can't vouch for that part.

Comment 8

[Pulsebot]

https://hg.mozilla.org/integration/b2g-inbound/rev/b165286b3b33

Comment 9

[Aus Lacroix [:aus]]

New tester docker image deployed to quay.io: rev [fbc904cd326b] on {https://quay.io/v1/repositories/mozilla/tester/tags/0.3.1}.

Comment 10

[Nigel Babu [:nigelb]]

Hello,

I see mullet failures since this landed. Can you take a look if it's caused by the update?

Comment 11

[James Lal [:lightsofapollo]]

Bam! Version conflict errors I think.... Can you rebase this and vbump again and try with a mulet push as well?

Comment 12

[Nigel Babu [:nigelb]]

Backed out in https://hg.mozilla.org/integration/b2g-inbound/rev/82cdcd396df9

Comment 13

[Pulsebot]

https://hg.mozilla.org/integration/b2g-inbound/rev/5d1121be7de5

Comment 14

[Nigel Babu [:nigelb]]

This is still busted on re-landing.

Comment 15

[Pulsebot]

https://hg.mozilla.org/integration/b2g-inbound/rev/eb674efe2b05

Comment 16

[Pulsebot]

https://hg.mozilla.org/integration/b2g-inbound/rev/c981ae453137

Comment 17

[Carsten Book [:Tomcat]]

seems this got backed out again aus ?

Comment 18

[Aus Lacroix [:aus]]

(In reply to Carsten Book [:Tomcat] from comment #17)
> seems this got backed out again aus ?

Yes, I was still seeing some failures. I re-based just now and will attempt to push again.

Comment 19

[Pulsebot]

https://hg.mozilla.org/integration/b2g-inbound/rev/5bfcb94f0d43
https://hg.mozilla.org/integration/b2g-inbound/rev/a8076bdf1ce7

Comment 20

[Aus Lacroix [:aus]]

OK. Let's hope the change sticks this time. :)

Comment 21

[Rail Aliiev [:rail]]

mozharness production tag moved to: https://hg.mozilla.org/build/mozharness/rev/1a2600cf03fc

Comment 22

[Rail Aliiev [:rail]]

mozharness production tag moved to: https://hg.mozilla.org/build/mozharness/rev/1a2600cf03fc

Comment 23

[Aus Lacroix [:aus]]

Looks like this is all happy and running as expected. I'm going to go ahead and mark this fixed. :)

Comment 24

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/5bfcb94f0d43
https://hg.mozilla.org/mozilla-central/rev/a8076bdf1ce7

Comment 25

[Pete Moore [:pmoore][:pete]]

Resetting Version and Target Milestone that accidentally got changed...