Closed Bug 1159972 Opened 8 years ago Closed 8 years ago

Remove the fallible version of PL_DHashTableInit()

Categories

(Core :: XPCOM, defect)

Product:
Core
Component:
XPCOM
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla40
Tracking Flags:
Tracking Status
firefox40 --- fixed

People

(Reporter: n.nethercote, Assigned: n.nethercote)

References

Details

Attachments

(1 file)

Remove the fallible version of PL_DHashTableInit()
20.61 KB, patch
froydnj
: review+
Details | Diff | Splinter Review 
Redoing, more cautiously, some stuff from bug 1050035 that had to be backed out for intermittent failures.
It's no longer needed now that entry storage isn't allocated there. (The other
possible causes of failures in that function are less interesting and simply
crashing is a reasonable thing to do for them.)

This also makes PL_DNewHashTable() infallible, so I removed some
now-unnecessary checks of its result.
Attachment #8599624 - Flags: review?(nfroyd)
Comment on attachment 8599624 [details] [diff] [review]
Remove the fallible version of PL_DHashTableInit()

Review of attachment 8599624 [details] [diff] [review]:
-----------------------------------------------------------------

Please post to dev-platform about this.
Attachment #8599624 - Flags: review?(nfroyd) → review+
https://hg.mozilla.org/mozilla-central/rev/efa98fd2a045
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
status-firefox40: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla40
You need to log in before you can comment on or make changes to this bug.