Closed Bug 1159987 Opened 5 years ago Closed 5 years ago

Improve Mirror/Canonical ergonomics by eliminating the ::Holder setup

Categories

(Core :: Audio/Video, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla40
Tracking Status
firefox40 --- fixed

People

(Reporter: bholley, Assigned: bholley)

References

Details

Attachments

(2 files)

I have some ideas here on how to make things a bit easier to use.
I fixed up the ::Holder stuff, and then decided that it makes sense to narrow the scope of this bug, because these patches will bitrot any other changes, so we should get them landed as quickly as possible.
Summary: Improve Mirror/Canonical ergonomics → Improve Mirror/Canonical ergonomics by eliminating the ::Holder setup
The current mechanism is slightly more pure from an implementation-perspective, but a lot more confusing for consumers. After some thought, I think we should flip them around.
    
This patch does Canonical - I'll do Mirror in the next patch.
Attachment #8599710 - Flags: review?(jwwang)
Attachment #8599710 - Flags: review?(jwwang) → review+
Attachment #8599711 - Flags: review?(jwwang) → review+
Thanks for the super-fast reviews! It's extremely helpful to keep things moving. :-)

https://treeherder.mozilla.org/#/jobs?repo=try&revision=8108fffbe41a
Blocks: 1160064
https://hg.mozilla.org/mozilla-central/rev/16e9873d1901
https://hg.mozilla.org/mozilla-central/rev/904ac0b85ffa
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla40
You need to log in before you can comment on or make changes to this bug.