1159987 - Improve Mirror/Canonical ergonomics by eliminating the ::Holder setup

Status: RESOLVED FIXED

(Core :: Audio/Video, defect)

Description

[Bobby Holley (:bholley)]

I have some ideas here on how to make things a bit easier to use.

Comment 1

[Bobby Holley (:bholley)]

I fixed up the ::Holder stuff, and then decided that it makes sense to narrow the scope of this bug, because these patches will bitrot any other changes, so we should get them landed as quickly as possible.

Comment 2

[Bobby Holley (:bholley)]

Attachment: Part 1 - Let consumers declare Canonical<T> rather than Canonical<T>::Holder. v1 (diff -w)

The current mechanism is slightly more pure from an implementation-perspective, but a lot more confusing for consumers. After some thought, I think we should flip them around.
    
This patch does Canonical - I'll do Mirror in the next patch.

Comment 3

[Bobby Holley (:bholley)]

Attachment: Part 2 - Let consumers declare Mirror<T> rather than Mirror<T>::Holder. v1 (diff -w)

Comment 4

[Bobby Holley (:bholley)]

Thanks for the super-fast reviews! It's extremely helpful to keep things moving. :-)

https://treeherder.mozilla.org/#/jobs?repo=try&revision=8108fffbe41a

Comment 5

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/16e9873d1901
https://hg.mozilla.org/integration/mozilla-inbound/rev/904ac0b85ffa

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/16e9873d1901
https://hg.mozilla.org/mozilla-central/rev/904ac0b85ffa