Closed Bug 1159991 Opened 9 years ago Closed 9 years ago

Include developer mode prefs in |DEVICE_DEBUG=1|

Categories

(Firefox OS Graveyard :: Gaia::Build, defect, P1)

Product:
Firefox OS Graveyard
Component:
Gaia::Build
Platform:
ARM
Gonk (Firefox OS)
Type:
defect

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: drs, Assigned: gduan)

References

Details

(Whiteboard: [spark])

Attachments

(1 file)

[gaia] cctuan:1159991 > mozilla-b2g:master
46 bytes, text/x-github-pull-request
rickychien
: review+
drs
: feedback+
Details | Review 
Currently, we have the following prefs tied to "developer mode", but not to |DEVICE_DEBUG=1|:
dom.apps.developer_mode = true,
network.disable.ipc.security = true,
dom.webcomponents.enabled = true

We should at least set 'dom.apps.developer_mode' to true when building with |DEVICE_DEBUG=1|, and potentially the others as well.
Fabrice, any thoughts on this?
Flags: needinfo?(fabrice)
That looks fine to me.
Flags: needinfo?(fabrice)
Assignee: nobody → drs
Blocks: spark-build
No longer blocks: spark
Hi Ricky, George, any chance either of you can take this? Would be much appreciated.
Assignee: drs → nobody
Flags: needinfo?(ricky060709)
Flags: needinfo?(gduan)
Assignee: nobody → gduan
Status: NEW → ASSIGNED
Flags: needinfo?(ricky060709)
Flags: needinfo?(gduan)
Comment on attachment 8604476 [details] [review]
[gaia] cctuan:1159991 > mozilla-b2g:master

Hi Ricky,
could you review this?
Thanks.
Attachment #8604476 - Flags: review?(ricky060709)
Attachment #8604476 - Flags: feedback?(drs)
Comment on attachment 8604476 [details] [review]
[gaia] cctuan:1159991 > mozilla-b2g:master

LGTM. r=me thanks!
Attachment #8604476 - Flags: review?(ricky060709) → review+
Comment on attachment 8604476 [details] [review]
[gaia] cctuan:1159991 > mozilla-b2g:master

Looks good to me, thanks for taking this!
Attachment #8604476 - Flags: feedback?(drs) → feedback+
I'm assuming that you're ok with landing this now.
Keywords: checkin-needed
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Blocks: spark-dev-mode
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: