1160110 - [Dialer] Not showing number on Choose SIM dialog

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::Shared, defect)

Description

[u495161]

Attachment: Choose SIM dialog

User Agent: Mozilla/5.0 (X11; Ubuntu; Linux x86_64; rv:38.0) Gecko/20100101 Firefox/38.0
Build ID: 20150424212335

Steps to reproduce:

- set Always ask for dialing in SIM Manager
- dial number


Actual results:

- choose sim dialog appearead
- it shows: "Dial 12345 via" always (see attachment)


Expected results:

- dialog should show "Dial <actual number> via"

Comment 1

[Derek Harris [:DerekH] - Dont need info. Last day 6/5/15]

This issue occurs when you long press on the Call button to select your SIM. This issue will also be visible when selecting which SIM to use when sending an SMS or MMS.

STR:
1) Have 2 SIM cards in the device
2) Open Dialer app
3) Type out a number
4) Long press on the "Call" button
5) Observe Header


This issue DOES occur on Flame 3.0

The header at the top reads as "Dial 12345 via"

Environmental Variables:
Device: Flame 3.0 (319mb)(Kitkat)(Full Flash)
Build ID: 20150508010203
Gaia: bc5bfa18f795919b56b952bbf3637c235d0e13dc
Gecko: 356e735fa908
Gonk: a9f3f8fb8b0844724de32426b7bcc4e6dc4fa2ed
Version: 40.0a1 (Master)
Firmware Version: v18D-1
User Agent: Mozilla/5.0 (Mobile; rv:40.0) Gecko/40.0 Firefox/40.0

========================================================================================================

This issue does NOT occur on Flame 2.2

The header at the top reads as "Select SIM"

Environmental Variables:
Device: Flame 2.2 (319mb)(Kitkat)(Full Flash)
Build ID: 20150508002501
Gaia: 88d3ac2721a5484495c2ed60e4a068945f0de5aa
Gecko: 8ad16ebe659d
Gonk: ab265fb203390c70b8f2a054f38cf4b2f2dad70a
Version: 37.0 (2.2)
Firmware Version: v18D-1
User Agent: Mozilla/5.0 (Mobile; rv:37.0) Gecko/37.0 Firefox/37.0

Comment 2

[Derek Harris [:DerekH] - Dont need info. Last day 6/5/15]

Attachment: logcat_20150508_1310.txt

A logcat of this issue occuring has been attached

Comment 3

[Peter Bylenga [:PBylenga]]

[Blocking Requested - why for this release]:
Visible regression, requesting a window.

Comment 4

[Yeojin Chung [:YeojinC]]

Mozilla-inbound Regression Window:

Last Working Environmental Variables:
Device: Flame 3.0
BuildID: 20150421204814
Gaia: 15134b080b5f406e5aa36f5136c17dafb4e31f64
Gecko: d3e10d7ea477
Version: 40.0a1 (3.0) 
Firmware Version: v18D-1
User Agent: Mozilla/5.0 (Mobile; rv:40.0) Gecko/40.0 Firefox/40.0

First Broken Environmental Variables:
Device: Flame 3.0
BuildID: 20150421220011
Gaia: 15134b080b5f406e5aa36f5136c17dafb4e31f64
Gecko: 25db40a4dd8e
Version: 40.0a1 (3.0) 
Firmware Version: v18D-1
User Agent: Mozilla/5.0 (Mobile; rv:40.0) Gecko/40.0 Firefox/40.0

Last Working Gaia First Broken Gecko: Issue DOES reproduce 
Gaia: 15134b080b5f406e5aa36f5136c17dafb4e31f64
Gecko: 25db40a4dd8e

First Broken Gaia Last Working Gecko: Issue NOT reproduce
Gaia: 15134b080b5f406e5aa36f5136c17dafb4e31f64
Gecko: d3e10d7ea477

http://hg.mozilla.org/integration/mozilla-inbound/pushloghtml?fromchange=d3e10d7ea477&tochange=25db40a4dd8e

possibly caused by bug 1013743

Comment 5

[KTucker [:KTucker][Inactive 3/4/2016]]

Olli, can you take a look at this please? Looks like this might have been caused by the landing for bug 1013743.

Comment 6

[Olli Pettay [:smaug][[e-mail]]]

Well bug 1013743 made MutationObserver work per spec.
Does something in Dialer use MutationObservers? Like, is it perhaps missing the fixes from
Bug 1130436?

Comment 7

[Olli Pettay [:smaug][[e-mail]]]

Where do we have the relevant code in Gaia?
I've found http://mxr.mozilla.org/gaia/source/apps/settings/elements/call_iccs.html?force=1#1, but
that doesn't show the number.

Comment 8

[Olli Pettay [:smaug][[e-mail]]]

kgrandon, perhaps you know? I'm all very unfamiliar with Gaia.

Comment 9

[GitHub Autolander Bot]

Attachment: [gaia] KevinGrandon:bug_1160110_dialer_sim_dialog_l10n > mozilla-b2g:master

Comment 10

[Kevin Grandon :kgrandon]

This is similar to the problem in bug 1130436 where we were relying on mutation observers to access the shadow DOM for localization. I've submitted a fix that I think is the easiest to manage here.

Comment 11

[Kevin Grandon :kgrandon]

Comment on attachment 8604570 [details] [review]
[gaia] KevinGrandon:bug_1160110_dialer_sim_dialog_l10n > mozilla-b2g:master

Anthony or Doug - could either of you take a look at this? This patch manually localizes the sim picker component after platform changes which make the l10n.js attributes not work from the shadow dom. We're still figuring out the long term component localization strategy, but for now I think that this workaround should suffice.

Comment 12

[Doug Sherk (:drs) (inactive)]

Comment on attachment 8604570 [details] [review]
[gaia] KevinGrandon:bug_1160110_dialer_sim_dialog_l10n > mozilla-b2g:master

I left a couple of nit-picky comments on the PR. I would prefer if this had tests, but I don't think it's worth the effort, given the circumstances.

Comment 13

[Kevin Grandon :kgrandon]

Thanks for the review. Needed to add a function to the l10n mock in bug 1164331. This should be good to land now.

Comment 14

[GitHub Autolander Bot]

Autolander could not locate a review from a user within the suggested reviewer list. Either the patch author or the reviewer should be in the suggested reviewer list.

Comment 15

[Kevin Grandon :kgrandon]

Oops, wrong component.

Comment 16

[GitHub Autolander Bot]

Pull request has landed in master: https://github.com/mozilla-b2g/gaia/commit/9c9c7862252fdbba852b283c93c349d19e1358b9

Comment 17

[GitHub Autolander Bot]

Attachment: [gaia] KevinGrandon:bug_1160110_localization_follow_up > mozilla-b2g:master

Comment 18

[Kevin Grandon :kgrandon]

Comment on attachment 8607112 [details] [review]
[gaia] KevinGrandon:bug_1160110_localization_follow_up > mozilla-b2g:master

Zibi - thanks for the advice, this is much nicer. Could you throw a review stamp on it if it looks right to you?

Comment 19

[Zibi Braniecki [:zbraniecki][:gandalf]]

Comment on attachment 8607112 [details] [review]
[gaia] KevinGrandon:bug_1160110_localization_follow_up > mozilla-b2g:master

Yeah :)

Comment 20

[GitHub Autolander Bot]

http://docs.taskcluster.net/tools/task-graph-inspector/#yF2NHagRSr24JRgXzSQaSw

The pull request failed to pass integration tests. It could not be landed, please try again.

Comment 21

[Kevin Grandon :kgrandon]

Manually landing the follow-up: https://github.com/mozilla-b2g/gaia/commit/099b611c0076ed9d8f68c569bba8c17f66a67f05

Comment 22

[u495161]

After a call, when I want to make another one, first number stays in dialog.

1. Call 123
2. Dialog shows 123
3. Call 321
4. Dialog still shows 123

Tested on:
Build ID: 20150517010201
Git Commit: 2015-05-15 22:18:51 4c0f36e9

Comment 23

[Kevin Grandon :kgrandon]

(In reply to Kamil from comment #22)
> After a call, when I want to make another one, first number stays in dialog.

Do you have any screenshots or a video? Let's see what our verification steps say here. That might be another bug.

Comment 24

[u495161]

I can't make video right now, but it looks like your localization code runs only once
And probably it should run on every Dial button press

Comment 25

[mac]

Attachment: video which shows that number doesn't refresh

I can confirm what Kamil wrote.

Platform 41.0a1
Got commit info: 2015-05-18 18:07:25

Video in the attachment. Video was made with use of Flatfish.

Comment 26

[Zibi Braniecki [:zbraniecki][:gandalf]]

Phone crashes on me with some Telemetry promise not being caught, so I can't test it.

Comment 27

[u495161]

I can see "Dial 12345 via" on the dialog again.

Build ID: 20150521022234
Git Commit: 2015-05-20 18:56:41 5a7f87b1

I don't have GCI or Build ID, but i could see it also after yesterdays OTA

Comment 28

[Julien Wajsberg [:julienw] (PTO -> may 13)]

The additional reported issue is the same than what I see in bug 1168060, I'll fix both there.

Comment 29

[Shally Li（leave from Mozilla）]

This bug has been verified as pass on latest Nightly build of Flame v3.0 by the STR in Comment 0 and Comment 12.

Actual results: The dialog will show "Dial <actual number> via" in Dialer.
See attachment: verified_v3.0.mp4
Reproduce rate: 0/5

Device: Flame v3.0 build(Pass)
Build ID               20150531160203
Gaia Revision          e6dc0f4c583407a4a52a66ce7cb11f058302a762
Gaia Date              2015-05-29 17:20:26
Gecko Revision         https://hg.mozilla.org/mozilla-central/rev/f8d21278244b
Gecko Version          41.0a1
Device Name            flame
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.cltbld.20150531.192324
Firmware Date          Sun May 31 19:23:35 EDT 2015
Bootloader             L1TC000118D0

Comment 30

[Shally Li（leave from Mozilla）]

Attachment: verified_v3.0.mp4