1160123 - Improve network selection choices

Status: RESOLVED FIXED

(Firefox OS Graveyard :: RIL, defect)

Description

[:gerard-majax]

I would like to make my device only select LTE and H+ networks, but this is not exposed in Settings app.

As far as I understand, this is coming from gecko, from the RIL_PREFERRED_NETWORK_TYPE_TO_GECKO: https://hg.mozilla.org/mozilla-central/annotate/4b9b12c248dc/dom/system/gonk/ril_consts.js#l405

However, in ril.h, I do see other entries in the RIL_PreferredNetworkType enum, like LTE_WCDMA: https://www.codeaurora.org/cgit/quic/la/platform/hardware/ril/tree/include/telephony/ril.h?h=b2g_kk_3.5#n138

Comment 1

[:gerard-majax]

Attachment: auto-lte-wcdma.gecko.patch

Comment 2

[:gerard-majax]

Attachment: auto-lte-wcdma.gaia.patch

Comment 3

[:gerard-majax]

It seems to be doing the job on my Z3 Compact build

Comment 4

[:gerard-majax]

Works as expected: LTE and H+ are working, and no EDGE gets connected :)

Comment 5

[Edgar Chen [:edgar] (PTO untils 8/11, slow response)]

Comment on attachment 8599847 [details] [diff] [review]
auto-lte-wcdma.gecko.patch

Review of attachment 8599847 [details] [diff] [review]:
-----------------------------------------------------------------

"PREF_NET_TYPE_LTE_WCDMA" is also included in AOSP 5.0.0 standard [1] (RIL version 10).
Thank you, Alexandre!!

[1] https://github.com/android/platform_hardware_ril/commit/0e09487471b09e45b5fc1b1588a600f35157079a

Comment 6

[Arthur Chen [:arthurcc][inactive after 6/30]]

Comment on attachment 8599848 [details] [diff] [review]
auto-lte-wcdma.gaia.patch

Review of attachment 8599848 [details] [diff] [review]:
-----------------------------------------------------------------

The patch is looking good to me, thanks. However, there is a new string regarding certificate added and I believe it should not be included in this patch.

::: apps/settings/locales/settings.en-US.properties
@@ +124,4 @@
>  enterCertificateNickname=Enter certificate nick name
>  nickname=Nick name
>  enter-certificate-name-msg=You can change the nick name or keep the default name.
> +enterCertificatePassowrd=Enter certificate password

Is this intentional?

Comment 7

[Hsin-Yi Tsai (she/her) | away [:hsinyi]]

Comment on attachment 8599848 [details] [diff] [review]
auto-lte-wcdma.gaia.patch

I believe Arthur's feedback is enough.

Comment 8

[:gerard-majax]

No Arthur, you're right, it's a leak from another patch I was trying :)

Comment 9

[:gerard-majax]

Edgar, Hsin-Yi, where should I add test case for the Gecko part of this ?

Comment 10

[:gerard-majax]

Arthur, which tests should I add for the Gaia part of this?

Comment 11

[Hsin-Yi Tsai (she/her) | away [:hsinyi]]

(In reply to Alexandre LISSY :gerard-majax from comment #9)
> Edgar, Hsin-Yi, where should I add test case for the Gecko part of this ?

Hi Alexandre, this is the test case you'd like to enhance.
https://dxr.mozilla.org/mozilla-central/source/dom/mobileconnection/tests/marionette/test_mobile_preferred_network_type.js?from=test_mobile_preferred_network_type.js&case=true#26

Thank you!

Comment 12

[Edgar Chen [:edgar] (PTO untils 8/11, slow response)]

See Hsin-Yi's feedback in comment #11. Thank you.

Comment 13

[:gerard-majax]

Attachment: Add support for LTE/WCDMA only network selection

FYI I cannot trigger any try request for now because of bug 1163609. This has
been running fine on both my Z3 Compact devices for several days now.

Comment 14

[GitHub Autolander Bot]

Attachment: [gaia] lissyx:bug1160123 > mozilla-b2g:master

Comment 15

[:gerard-majax]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=892372b4ce06

Comment 16

[Arthur Chen [:arthurcc][inactive after 6/30]]

Comment on attachment 8604123 [details] [review]
[gaia] lissyx:bug1160123 > mozilla-b2g:master

r=me with the comment addressed, thanks!

Comment 17

[Hsin-Yi Tsai (she/her) | away [:hsinyi]]

Comment on attachment 8604115 [details] [diff] [review]
Add support for LTE/WCDMA only network selection

Review of attachment 8604115 [details] [diff] [review]:
-----------------------------------------------------------------

Thank you.

Comment 18

[GitHub Autolander Bot]

Autolander could not locate a review from a user within the suggested reviewer list. Either the patch author or the reviewer should be in the suggested reviewer list.

Comment 19

[Kevin Grandon :kgrandon]

Moving to the settings component to get this landed. Might need to add checkin-needed afer this lands for the gecko part as well.

Comment 20

[GitHub Autolander Bot]

Pull request has landed in master: https://github.com/mozilla-b2g/gaia/commit/17406612b349d3ba877dbf20bc3ec42bf77a8b2b

Comment 21

[:gerard-majax]

Now checkin-needed for Gecko part

Comment 22

[GitHub Autolander Bot]

Autolander could not locate a review from a user within the suggested reviewer list. Either the patch author or the reviewer should be in the suggested reviewer list.

Comment 23

[Kevin Grandon :kgrandon]

Comment on attachment 8604123 [details] [review]
[gaia] lissyx:bug1160123 > mozilla-b2g:master

I am going to obsolete this for the time being to keep checkin-needed for the gecko patch. (We can un-obsolete it afterwards most likely)

Comment 24

[Kevin Grandon :kgrandon]

Adding checkin-needed for the gecko patch.

Comment 25

[Pulsebot]

https://hg.mozilla.org/integration/b2g-inbound/rev/809ab9084cc2

Comment 26

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/809ab9084cc2