Closed
Bug 1160171
Opened 11 years ago
Closed 11 years ago
Web Components Spark: Buttons have an unrefined press state
Categories
(Firefox OS Graveyard :: Gaia::Components, defect)
Firefox OS Graveyard
Gaia::Components
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: padamczyk, Assigned: gasolin)
References
Details
(Keywords: polish)
Attachments
(2 files)
|
68.42 KB,
image/png
|
Details | |
|
53 bytes,
text/x-github-pull-request
|
wilsonpage
:
review+
harly
:
ui-review+
harly
:
ui-review+
|
Details | Review |
Please refer the web components repo created by Wilson viewed in Nightly: http://gaia-components.github.io/gaia-components/
When a button is pressed, you can see the bounding rectangle and they often have an aliased outline. See screenshot for the buttons I am referring to.
| Reporter | ||
Updated•11 years ago
|
Component: Gaia::System → Gaia::Components
| Assignee | ||
Comment 1•11 years ago
|
||
| Assignee | ||
Comment 2•11 years ago
|
||
Comment on attachment 8601346 [details] [review]
pull request redirect to github
Though it's not a direct fix with press-rectangle issue, but after applying this PR (mainly lint and dependency package update), the press-rectangle issue is gone.
Set harly & jenny to UI review for gaia-button and see if we can pump it to `can Use` state in https://wiki.mozilla.org/Gaia/Shared/Components
Attachment #8601346 -
Flags: ui-review?(jelee)
Attachment #8601346 -
Flags: ui-review?(hhsu)
Attachment #8601346 -
Flags: review?(wilsonpage)
Comment 4•11 years ago
|
||
Comment on attachment 8601346 [details] [review]
pull request redirect to github
LGTM, thanks Fred :)
Attachment #8601346 -
Flags: ui-review?(jelee)
Attachment #8601346 -
Flags: ui-review?(hhsu)
Attachment #8601346 -
Flags: ui-review+
Updated•11 years ago
|
Attachment #8601346 -
Flags: review?(wilsonpage) → review+
Updated•11 years ago
|
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
| Assignee | ||
Updated•11 years ago
|
Assignee: nobody → gasolin
| Assignee | ||
Comment 5•11 years ago
|
||
You need to log in
before you can comment on or make changes to this bug.
Description
•