Closed Bug 1160293 Opened 5 years ago Closed 5 years ago

Spark Wallpapers

Categories

(Firefox OS Graveyard :: Gaia::Wallpaper, defect, P1)

ARM
Gonk (Firefox OS)
defect

Tracking

(Not tracked)

RESOLVED FIXED
2.2 S13 (29may)

People

(Reporter: padamczyk, Assigned: daleharvey)

References

Details

(Whiteboard: [spark][systemsfe])

Attachments

(2 files, 1 obsolete file)

Attached file wallpapers.zip (obsolete) —
Attached are the new spark wallpapers. Can you make "Illus_Spark_Orbit@2.25x.jpg" the default wallpaper. I ran all the wallpapers through a JPG compressor.

And can you please exclude all the wallpapers with the prefix "FX_" & "Flat_" from these builds. Thanks!
Attached file wallpapers.zip
Attachment #8600055 - Attachment is obsolete: true
This will be using the Gaia customization framework, so I'm assigning it to Ted.
Assignee: drs → tclancy
Blocks: spark-build
No longer blocks: spark
Priority: -- → P1
Whiteboard: [spark]
Ted says he is getting busy with bidi things, so gonna take this one
Assignee: tclancy → dale
Hey David

The market customisation guides (https://developer.mozilla.org/en-US/Firefox_OS/Developing_Gaia/Market_customizations_guide#wallpapers.2F) say a path can be used in settings.json for the wallpaper.image value, do you know how I can get that to work? I attempted |Illus_Spark_Orbit.jpg| or |wallpapers/Illus_Spark_Orbit.jpg| and neither value seemed to pick up.

Would really like to avoid using a data uri here if possible since it makes the file unusable / unweildy

Cheers
Flags: needinfo?(dflanagan)
Dale,

I know the wallpaper app and the wallpaper manager code in the system app, but not the build time code that sets the default or how the customization stuff works. Sorry I can't help.
Flags: needinfo?(dflanagan)
George, any ideas about https://bugzilla.mozilla.org/show_bug.cgi?id=1160293#c5 or at least who I would ping?
Flags: needinfo?(gduan)
I think it's probably a bug which doesn't meet what MDN states.

https://github.com/mozilla-b2g/gaia/blob/master/build/settings.js#L18
you probably need to rename it as default.jpg

https://github.com/mozilla-b2g/gaia/blob/master/build/settings.js#L189
or transfer it as a data uri

or create a new method 'overrideWallper' in below , to transfer filePath to data uri (similar as what setWallpaper does)
https://github.com/mozilla-b2g/gaia/blob/master/build/settings.js#L187
Flags: needinfo?(gduan)
Awesome thanks George, worked great
Comment on attachment 8610524 [details] [review]
[gaia] daleharvey:1160293 > mozilla-b2g:master

Due to https://bugzilla.mozilla.org/show_bug.cgi?id=1168828 may still need to flash twice for this to take effect
Attachment #8610524 - Flags: review?(drs)
Comment on attachment 8610524 [details] [review]
[gaia] daleharvey:1160293 > mozilla-b2g:master

Looks good, thanks.
Attachment #8610524 - Flags: review?(drs) → review+
https://github.com/mozilla-b2g/gaia/commit/21f22a84becf80a931418ccbb21074489e30441e
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Whiteboard: [spark] → [spark][systemsfe]
Target Milestone: --- → 2.2 S13 (29may)
You need to log in before you can comment on or make changes to this bug.