1160293 - Spark Wallpapers

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Wallpaper, defect, P1)

Description

[Patryk Adamczyk [:patryk] UX]

Attachment: wallpapers.zip

Attached are the new spark wallpapers. Can you make "[e-mail]" the default wallpaper. I ran all the wallpapers through a JPG compressor.

And can you please exclude all the wallpapers with the prefix "FX_" & "Flat_" from these builds. Thanks!

Comment 1

[Patryk Adamczyk [:patryk] UX]

Attachment: wallpapers.zip

Comment 2

[Doug Sherk (:drs) (inactive)]

This will be using the Gaia customization framework, so I'm assigning it to Ted.

Comment 3

[Dale Harvey (:daleharvey)]

Ted says he is getting busy with bidi things, so gonna take this one

Comment 4

[GitHub Autolander Bot]

Attachment: [gaia] daleharvey:1160293 > mozilla-b2g:master

Comment 5

[Dale Harvey (:daleharvey)]

Hey David

The market customisation guides (https://developer.mozilla.org/en-US/Firefox_OS/Developing_Gaia/Market_customizations_guide#wallpapers.2F) say a path can be used in settings.json for the wallpaper.image value, do you know how I can get that to work? I attempted |Illus_Spark_Orbit.jpg| or |wallpapers/Illus_Spark_Orbit.jpg| and neither value seemed to pick up.

Would really like to avoid using a data uri here if possible since it makes the file unusable / unweildy

Cheers

Comment 6

[David Flanagan [:djf]]

Dale,

I know the wallpaper app and the wallpaper manager code in the system app, but not the build time code that sets the default or how the customization stuff works. Sorry I can't help.

Comment 7

[Dale Harvey (:daleharvey)]

George, any ideas about https://bugzilla.mozilla.org/show_bug.cgi?id=1160293#c5 or at least who I would ping?

Comment 8

[(Inactive after June) George Duan [:gduan] [:喬智]]

I think it's probably a bug which doesn't meet what MDN states.

https://github.com/mozilla-b2g/gaia/blob/master/build/settings.js#L18
you probably need to rename it as default.jpg

https://github.com/mozilla-b2g/gaia/blob/master/build/settings.js#L189
or transfer it as a data uri

or create a new method 'overrideWallper' in below , to transfer filePath to data uri (similar as what setWallpaper does)
https://github.com/mozilla-b2g/gaia/blob/master/build/settings.js#L187

Comment 9

[Dale Harvey (:daleharvey)]

Awesome thanks George, worked great

Comment 10

[Dale Harvey (:daleharvey)]

Comment on attachment 8610524 [details] [review]
[gaia] daleharvey:1160293 > mozilla-b2g:master

Due to https://bugzilla.mozilla.org/show_bug.cgi?id=1168828 may still need to flash twice for this to take effect

Comment 11

[Doug Sherk (:drs) (inactive)]

Comment on attachment 8610524 [details] [review]
[gaia] daleharvey:1160293 > mozilla-b2g:master

Looks good, thanks.

Comment 12

[Doug Sherk (:drs) (inactive)]

https://github.com/mozilla-b2g/gaia/commit/21f22a84becf80a931418ccbb21074489e30441e