1160311 - Enable the JITs by default on a JSRuntime

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Description

[Boris Zbarsky [:bzbarsky]]

This keeps biting people.  We should default to sane fast mode.  ;)

I audited our internal stuff an the only case that will change behavior is the PAC runtime and some JSAPI tests; everyone else overrides the runtime options anyway.  I think that's OK.

Comment 1

[Boris Zbarsky [:bzbarsky]]

Attachment: JITs should be enabled by default

Comment 2

[Jason Orendorff [:jorendorff]]

Comment on attachment 8600078 [details] [diff] [review]
JITs should be enabled by default

Review of attachment 8600078 [details] [diff] [review]:
-----------------------------------------------------------------

Thank you, bz.

Comment 3

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/2736f8056026

Comment 4

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

Looks like SM(e) and SM(r) didn't like this: 
https://treeherder.mozilla.org/logviewer.html#?job_id=9464865&repo=mozilla-inbound
https://hg.mozilla.org/integration/mozilla-inbound/rev/fd384372c651

Comment 5

[Boris Zbarsky [:bzbarsky]]

Filed bug 1160414 on the broken chromeonly recursion ballast when jit is enabled.

Comment 6

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/53fadc2749bb

Comment 7

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/83082fcebedc

Comment 8

[Mike Hommey [:glandium]]

What's the consequence for platforms without a jit?

Comment 9

[Boris Zbarsky [:bzbarsky]]

What do those platforms do right now?  Firefox windows already enable the jit (based on prefs).  So do web workers.  So does the JS shell.

This change mostly affects embeddings, plus, in our tree, JSAPI tests and PAC.

That said, I suspect (though I have not verified) that no JIT means no JIT even if the runtime option says trying to JIT would be OK.

Comment 10

[Jan de Mooij [:jandem]]

(In reply to Not doing reviews right now from comment #9)
> That said, I suspect (though I have not verified) that no JIT means no JIT
> even if the runtime option says trying to JIT would be OK.

Right, if you build without a JIT these options have no effect.

Comment 11

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/53fadc2749bb
https://hg.mozilla.org/mozilla-central/rev/83082fcebedc