1160339 - nsContextMenu.linkText should be a function to keep addon-compat

Status: RESOLVED FIXED

(Firefox :: Menus, defect)

Description

[Ian Moody [:Kwan] (UTC+0)]

See bug 1134222 comment 14

I changed nsContextMenu.linkText to be a string but addons are using it and expecting it to still be a function

Comment 1

[Ian Moody [:Kwan] (UTC+0)]

Attachment: MozReview Request: bz://1160339/Kwan

/r/7965 - Bug 1160339 - Make nsContextMenu.linkText a function again for addon-compat

Pull down this commit:

hg pull -r 993d66b0137be4a8d85ec06c6ec0cc0d8b4e7a43 https://reviewboard-hg.mozilla.org/gecko/

Comment 2

[Mike Conley (:mconley) (:⚙️)]

Comment on attachment 8600106 [details]
MozReview Request: bz://1160339/Kwan

https://reviewboard.mozilla.org/r/7963/#review6771

Ship It!

Comment 3

[Ian Moody [:Kwan] (UTC+0)]

Green auto-land try run on reviewboard.

(Didn't mean to remove the blocking 1160339 before, mid-aired myself with the comment)

Comment 4

[Ryan VanderMeulen [:RyanVM]]

Needs rebasing.

Comment 5

[Ian Moody [:Kwan] (UTC+0)]

(In reply to Ryan VanderMeulen [:RyanVM UTC-4] from comment #4)
> Needs rebasing.

Unfortunate timing with bug 1134769.  Done.

Comment 6

[Ian Moody [:Kwan] (UTC+0)]

Comment on attachment 8600106 [details]
MozReview Request: bz://1160339/Kwan

/r/7965 - Bug 1160339 - Make nsContextMenu.linkText a function again for addon-compat

Pull down this commit:

hg pull -r 68b36cdb7c4a8f4a462ee5295690e5fb936f8671 https://reviewboard-hg.mozilla.org/gecko/

Comment 7

[Mike Conley (:mconley) (:⚙️)]

Comment on attachment 8600106 [details]
MozReview Request: bz://1160339/Kwan

https://reviewboard.mozilla.org/r/7963/#review6783

Ship It!

Comment 8

[Pulsebot]

https://hg.mozilla.org/integration/fx-team/rev/47ea4e2d91ed

Comment 9

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/47ea4e2d91ed

Comment 10

[Ian Moody [:Kwan] (UTC+0)]

Attachment: Aurora patch

Approval Request Comment
[Feature/regressing bug #]: bug 1134222
[User impact if declined]: breaks add-on compat, see bug 1134222 comment 14 and bug 1134222 comment 17
[Describe test coverage new/current, TreeHerder]: I believe browser/base/content/test/general/browser_bug970746.js exercises a function that uses the renamed string
[Risks and why]: Low. Code change is minimal (variable rename, and creation of minimal function), and restores the currently expected and used by add-on behaviour
[String/UUID change made/needed]: none

Comment 11

[Liz Henry (:lizzard) (privacy/fingerprinting team)]

If the regression is from bug 1134222, that patch only landed 2 weeks ago, so that wouldn't have affected 39. 

Ian, is this definitely an issue in 39? Was there some other bug that would have affected aurora?

Comment 12

[Ian Moody [:Kwan] (UTC+0)]

(In reply to Liz Henry (:lizzard) from comment #11)
> If the regression is from bug 1134222, that patch only landed 2 weeks ago,
> so that wouldn't have affected 39. 
> 
> Ian, is this definitely an issue in 39? Was there some other bug that would
> have affected aurora?
It is definitely an issue. Bug 1134222 only closed two weeks ago because its dependent bug 1140859 was fixed then, but the problematic landing made it to central on 21st March: bug 1134222 comment 7

https://hg.mozilla.org/releases/mozilla-aurora/rev/1fe96992c3b5

Comment 13

[Liz Henry (:lizzard) (privacy/fingerprinting team)]

Comment on attachment 8600528 [details] [diff] [review]
Aurora patch

Approved for uplift to aurora to avoid shipping 39 with this regression; this has some test coverage and some time on m-c.

Comment 14

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/c67ad1e64f00

Comment 16

[Ian Moody [:Kwan] (UTC+0)]

Attachment: MozReview Request: Bug 1160339 - Make nsContextMenu.linkText a function again for addon-compat