Closed Bug 1160339 Opened 9 years ago Closed 9 years ago

nsContextMenu.linkText should be a function to keep addon-compat

Categories

(Firefox :: Menus, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
Firefox 40
Tracking Status
firefox39 --- fixed
firefox40 --- fixed

People

(Reporter: Kwan, Assigned: Kwan)

References

Details

(Keywords: addon-compat, regression)

Attachments

(2 files, 1 obsolete file)

See bug 1134222 comment 14

I changed nsContextMenu.linkText to be a string but addons are using it and expecting it to still be a function
Attached file MozReview Request: bz://1160339/Kwan (obsolete) —
/r/7965 - Bug 1160339 - Make nsContextMenu.linkText a function again for addon-compat

Pull down this commit:

hg pull -r 993d66b0137be4a8d85ec06c6ec0cc0d8b4e7a43 https://reviewboard-hg.mozilla.org/gecko/
Attachment #8600106 - Flags: review?(mconley)
No longer blocks: 1134222
Attachment #8600106 - Flags: review+
Attachment #8600106 - Flags: review?(mconley) → review+
Green auto-land try run on reviewboard.

(Didn't mean to remove the blocking 1160339 before, mid-aired myself with the comment)
Blocks: 1134222
Keywords: checkin-needed
Needs rebasing.
Keywords: checkin-needed
(In reply to Ryan VanderMeulen [:RyanVM UTC-4] from comment #4)
> Needs rebasing.

Unfortunate timing with bug 1134769.  Done.
Keywords: checkin-needed
Comment on attachment 8600106 [details]
MozReview Request: bz://1160339/Kwan

/r/7965 - Bug 1160339 - Make nsContextMenu.linkText a function again for addon-compat

Pull down this commit:

hg pull -r 68b36cdb7c4a8f4a462ee5295690e5fb936f8671 https://reviewboard-hg.mozilla.org/gecko/
Attachment #8600106 - Flags: review?(mconley)
Attachment #8600106 - Flags: review+
Attachment #8600106 - Flags: review?(mconley) → review+
https://hg.mozilla.org/mozilla-central/rev/47ea4e2d91ed
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 40
Attached patch Aurora patchSplinter Review
Approval Request Comment
[Feature/regressing bug #]: bug 1134222
[User impact if declined]: breaks add-on compat, see bug 1134222 comment 14 and bug 1134222 comment 17
[Describe test coverage new/current, TreeHerder]: I believe browser/base/content/test/general/browser_bug970746.js exercises a function that uses the renamed string
[Risks and why]: Low. Code change is minimal (variable rename, and creation of minimal function), and restores the currently expected and used by add-on behaviour
[String/UUID change made/needed]: none
Attachment #8600528 - Flags: approval-mozilla-aurora?
If the regression is from bug 1134222, that patch only landed 2 weeks ago, so that wouldn't have affected 39. 

Ian, is this definitely an issue in 39? Was there some other bug that would have affected aurora?
Flags: needinfo?(moz-ian)
Keywords: regression
(In reply to Liz Henry (:lizzard) from comment #11)
> If the regression is from bug 1134222, that patch only landed 2 weeks ago,
> so that wouldn't have affected 39. 
> 
> Ian, is this definitely an issue in 39? Was there some other bug that would
> have affected aurora?
It is definitely an issue. Bug 1134222 only closed two weeks ago because its dependent bug 1140859 was fixed then, but the problematic landing made it to central on 21st March: bug 1134222 comment 7

https://hg.mozilla.org/releases/mozilla-aurora/rev/1fe96992c3b5
Flags: needinfo?(moz-ian)
Comment on attachment 8600528 [details] [diff] [review]
Aurora patch

Approved for uplift to aurora to avoid shipping 39 with this regression; this has some test coverage and some time on m-c.
Attachment #8600528 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Attachment #8600106 - Attachment is obsolete: true
Attachment #8620208 - Flags: review+
You need to log in before you can comment on or make changes to this bug.